Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement box model test from 2001 JCP paper #151

Merged
merged 36 commits into from
Oct 22, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
3d7e193
Add gbox80 grid configuration
Jun 20, 2018
5c7d7bc
Add option files for the box2001 case (Hunke, E.C., 2001. Viscout-pl…
Jun 20, 2018
aeacd1e
Modifications and additions to F90 files required for the box2001 case
Jun 20, 2018
a6bcb95
Update box2001 namelist file to have both N/S and E/W boundary types …
Jun 21, 2018
e1f4d2e
modifications to allow for constant coriolis
Jul 9, 2018
23ea0fc
modifications for updates to namelist file
Jul 9, 2018
0c793f7
Update ice_in to include coriolis and x/y_spacing variables
Jul 9, 2018
b5fe395
replace x_spacing and y_spacing with dxrect and dyrect in the namelists
Aug 2, 2018
3fd0afe
Add to the box2001 namelist file
Aug 6, 2018
52a0b51
Add new 'thermo' namelist variable to disable thermodynamics. Add co…
Sep 12, 2018
266af9e
Update rectgrid subroutine to set a land mask of 2 grid points around…
Sep 12, 2018
4e8140c
Update user-guide case settings documentation to include the new name…
Sep 12, 2018
c363c30
Fix bug in documentation added in previous commit for box2001
Sep 12, 2018
e843dab
More updates to user guide case settings for box2001 test case
Sep 12, 2018
be79463
Remove duplicate namelist definition in user guide testing
Sep 12, 2018
e8cefca
Add description of box2001 test to the testing documentation
Sep 12, 2018
4a0ef80
Typo fix in documentation
Sep 12, 2018
d3e2a94
Fix indentation
Sep 13, 2018
9d647c8
Updates to remove the thermo namelist variable, and instead turn off …
Sep 21, 2018
f66a56d
Modifications to not call init_flux_* in cice_run if the 2001 test ca…
Sep 28, 2018
d7d095b
Add new kridge and ktransport namelist options, as well as conditiona…
Oct 9, 2018
88b1010
Merge branch 'master' into box2001
mattdturner Oct 11, 2018
e3bea89
Resolve namelist errors that were introduced during the merge conflic…
Oct 11, 2018
a3784d1
Fix a bug that caused binary data to be written to the log file
Oct 12, 2018
428278a
Remove unused variables from ice_step
Oct 15, 2018
52eaef9
Remove unused variables from ice_forcing file
Oct 16, 2018
724f96f
initialize ice state
eclare108213 Oct 17, 2018
eba943c
replace land_override with close_boundaries.
Oct 19, 2018
6e349b8
Replace 'default' with 'latitude' as the default coriolis value
Oct 19, 2018
4611adb
Update documentation to include new namelist variables kridge and ktr…
Oct 19, 2018
64f0d92
Merge branch 'master' into box2001
mattdturner Oct 19, 2018
bd675af
Re-add dxrect and dyrect as variables in ice_init. This was a bug in…
Oct 19, 2018
6e5109d
correct configuration options
eclare108213 Oct 20, 2018
2689ed4
miscellaneous updates, increased run length
eclare108213 Oct 20, 2018
4626b06
use strax,y (input directly) instead of strairx,yT (calculated) and s…
eclare108213 Oct 21, 2018
5e1b713
Update CICE_RunMod conditionals from 'ktherm > 0' to 'ktherm >= 0' si…
Oct 22, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into box2001
  • Loading branch information
mattdturner authored Oct 11, 2018
commit 88b10109fc9d99366f407c8b7ae7d6b8c46b270d
16 changes: 14 additions & 2 deletions cicecore/cicedynB/general/ice_init.F90
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,13 @@ subroutine input_data

use ice_broadcast, only: broadcast_scalar, broadcast_array
use ice_diagnostics, only: diag_file, print_global, print_points, latpnt, lonpnt
use ice_domain_size, only: max_nstrm, nilyr, nslyr, max_ntrcr, ncat, n_aero
use ice_domain, only: land_override
use ice_domain_size, only: ncat, nilyr, nslyr, nblyr, &
n_aero, n_zaero, n_algae, &
n_doc, n_dic, n_don, n_fed, n_fep, &
n_trbgcz, n_trzs, n_trbri, n_trzaero, &
n_trage, n_trfy, n_trlvl, n_trpnd, n_trbgcs, &
n_bgc, nltrcr, max_nsw, max_ntrcr, max_nstrm
use ice_calendar, only: year_init, istep0, histfreq, histfreq_n, &
dumpfreq, dumpfreq_n, diagfreq, &
npt, dt, ndtd, days_per_year, use_leap_years, &
Expand Down Expand Up @@ -144,6 +149,7 @@ subroutine input_data

namelist /grid_nml/ &
grid_format, grid_type, grid_file, kmt_file, &
ncat, nilyr, nslyr, nblyr, &
kcatbound, gridcpl_file, dxrect, dyrect, &
land_override

Expand Down Expand Up @@ -951,7 +957,13 @@ subroutine input_data
kcatbound
write(nu_diag,1020) ' land_override = ', &
land_override
write(nu_diag,1020) ' kdyn = ', kdyn
if (kdyn == 1) then
write(nu_diag,1021) ' kdyn = ','evp ', kdyn
elseif (kdyn == 2) then
write(nu_diag,1021) ' kdyn = ','eap ', kdyn
else
write(nu_diag,1020) ' kdyn = ', kdyn
endif
write(nu_diag,1020) ' ndtd = ', ndtd
write(nu_diag,1020) ' ndte = ', ndte
write(nu_diag,1010) ' revised_evp = ', &
Expand Down
3 changes: 0 additions & 3 deletions cicecore/cicedynB/infrastructure/ice_grid.F90
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,6 @@ subroutine init_grid1
use ice_blocks, only: nx_block, ny_block
use ice_broadcast, only: broadcast_array
use ice_constants, only: c1
use ice_domain_size, only: max_blocks
use ice_domain, only: land_override

integer (kind=int_kind) :: &
fid_grid, & ! file id for netCDF grid file
Expand Down Expand Up @@ -1122,7 +1120,6 @@ subroutine rectgrid
use ice_blocks, only: nx_block, ny_block
use ice_constants, only: c0, c1, c2, radius, cm_to_m, &
field_loc_center, field_loc_NEcorner, field_type_scalar
use ice_domain_size, only: max_blocks
use ice_domain, only: land_override

integer (kind=int_kind) :: &
Expand Down
8 changes: 4 additions & 4 deletions cicecore/drivers/cice/CICE_RunMod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ subroutine CICE_Run

use ice_calendar, only: istep, istep1, time, dt, stop_now, calendar
use ice_forcing, only: get_forcing_atmo, get_forcing_ocn, atm_data_type
use ice_forcing_bgc, only: get_forcing_bgc, get_atm_bgc, fzaero_data, &
use ice_forcing_bgc, only: get_forcing_bgc, get_atm_bgc, &
faero_default
use ice_flux, only: init_flux_atm, init_flux_ocn
use ice_timers, only: ice_timer_start, ice_timer_stop, &
Expand All @@ -56,6 +56,7 @@ subroutine CICE_Run
tr_aero, tr_zaero, skl_bgc, z_tracers
integer (kind=int_kind) :: &
land_override ! if=1, set land on edges of outer 2 rows/columns
character(len=*), parameter :: subname = '(CICE_Run)'

!--------------------------------------------------------------------
! initialize error code and step timer
Expand Down Expand Up @@ -139,8 +140,7 @@ subroutine ice_step
use ice_calendar, only: dt, dt_dyn, ndtd, diagfreq, write_restart, istep
use ice_diagnostics, only: init_mass_diags, runtime_diags
use ice_diagnostics_bgc, only: hbrine_diags, zsal_diags, bgc_diags
use ice_domain, only: halo_info, nblocks, land_override
use ice_domain_size, only: nslyr
use ice_domain, only: halo_info, nblocks
use ice_dyn_eap, only: write_restart_eap
use ice_dyn_shared, only: kdyn, kridge, ktransport
use ice_flux, only: scale_factor, init_history_therm, &
Expand Down Expand Up @@ -213,7 +213,7 @@ subroutine ice_step
! Scale radiation fields
!-----------------------------------------------------------------
if(ktherm.gt.0) then
if (calc_Tsfc) call prep_radiation (dt, iblk)
if (calc_Tsfc) call prep_radiation (iblk)

!-----------------------------------------------------------------
! thermodynamics and biogeochemistry
Expand Down
4 changes: 4 additions & 0 deletions configuration/scripts/ice_in
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@
maskhalo_dyn = .false.
maskhalo_remap = .false.
maskhalo_bound = .false.
ncat = 5
nilyr = 7
nslyr = 1
nblyr = 7
/

&tracer_nml
Expand Down
4 changes: 4 additions & 0 deletions doc/source/user_guide/ug_case_settings.rst
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,10 @@ Table of namelist options
"", "``-1``", "one category", ""
"``dxrect``", "real", "x-direction grid spacing (meters) for rectangular grid", ""
"``dyrect``", "real", "y-direction grid spacing (meters) for rectangular grid", ""
"``ncat``", "integer", "number of ice thickness categories", "5"
"``nilyr``", "integer", "number of vertical layers in ice", "7"
"``nslyr``", "integer", "number of vertical layers in snow", "1"
"``nblyr``", "integer", "number of zbgc layers", "7"
"", "", "", ""
"*domain_nml*", "", "", ""
"", "", "*Domain*", ""
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.