-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESPG=4326 is not recognised #69
Comments
The function docstring says:
if that is the case, and a That being said, since |
Actually as I progress doing our Iceland test case, I found more bugs/fixes to implement in various functions.
some functions implement the |
@tomsail no, I can follow. feel free. thanks for putting in the effort here. |
This is one of the reasons that the CI actions don't pass:
Some of the examples in the README use EPSG = 4326 as an integer for the coordinate system.
However in edgefx.py, only strings are tested i.e. :
if crs == "EPSG:4326":
like in
bathymetric_gradient_sizing_function()
andwavelength_sizing_function()
if crs == "EPSG:4326" or crs == 4326:
seems to be a good fix
The text was updated successfully, but these errors were encountered: