Fix for segfault on reference to mw_exp when using JRDN snow layering
#445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartnijssen
reviewed
Jan 11, 2021
build/source/engine/snowLiqFlx.f90
Outdated
| ! This implementation can result in a segfault when using JRDN layering. | ||
| ! The segfault occurs when trying to access `mw_exp` in: | ||
| ! iLayerLiqFluxSnow(iLayer) = k_snow*relSaturn**mw_exp | ||
| ! Debugging found that the `pack` statement cased `mw_exp` to no longer be accessible. |
There was a problem hiding this comment.
fix type 'cased' --> 'caused'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, when using JRDN snow layering I have run into segfaults on reference to
mw_exp(only when doing scalar solutions) in the line:after some debugging it turns out this loss of access to
mw_expoccurs directly following thepackstatement:I have not been able to determine the exact reason for this error, but have developed a workaround, which is provided in this PR.
Solves #446