Add opt-out option and profile tracking #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahsturgeon
added
bug
| _getToken: => getToken! | ||
|
|
||
| _getTimestamp: => getTimestamp! | ||
|
|
There was a problem hiding this comment.
Not really following why you did this?
There was a problem hiding this comment.
The other classes inherit this, but these values are defined locally in this file
sarahsturgeon
force-pushed
the
feature/add-tracking
branch
from
47f4000 to
61278d1
Compare
sarahsturgeon
force-pushed
the
feature/add-tracking
branch
from
33514fc to
5c996a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out Mixpanel doesn't create profiles for users, even if you're passing them a distinct ID.
We'll have to manually create a new profile for each player if we want to be able to treat
disctint_idsas references in our data.