Fix to properly run the command within the docker instance.#39
Closed
jmfernandez wants to merge 1 commit intoCESNET:mainfrom
Closed
Fix to properly run the command within the docker instance.#39jmfernandez wants to merge 1 commit intoCESNET:mainfrom
jmfernandez wants to merge 1 commit intoCESNET:mainfrom
Conversation
Not all the images have to have `/bin/sh` shell, and the command line itself is obtained from the received TES request.
Member
|
thank you @jmfernandez -- should be implemented in #45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all the docker images have to have
/bin/shshell,and the command line itself is obtained from the received TES request.
So, instead of writing the command to a shell script, and running the shell script within the container instance, the patch makes docker running the command within the container instance.
If this patch is accepted, some janitorial work would be needed, as all the script generation and permissions setting machinery could be removed.
Also, a similar change should be applied for the scenarios where singularity is being used instead of docker