Skip to content

Feature/add defaults module option #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Feature/add defaults module option #110

wants to merge 1 commit into from

Conversation

steweg
Copy link
Contributor

@steweg steweg commented Mar 8, 2024

No description provided.

@steweg steweg force-pushed the feature/add_defaults_module_option branch from 84cbef5 to 879fcf8 Compare March 8, 2024 09:05
@steweg steweg marked this pull request as ready for review March 8, 2024 09:06
rjarry
rjarry requested changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@rjarry rjarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

libyang-python only supports the master branch of C libyang (currently 2.x).

The lydevel check is only meant for informative purposes.

libyang-python/tox.ini

Lines 18 to 20 in f09ed11

[testenv:lydevel]
setenv =
LIBYANG_BRANCH=devel

If it fails (currently it should fail because libyang 3.x is under development) it is not a problem.

Could you remove all references to libyang 3 which was not released yet and only focus on the enhancements that you require?

Thank you.

@steweg steweg force-pushed the feature/add_defaults_module_option branch from 879fcf8 to 5ce7f2d Compare March 29, 2024 16:10
@steweg
Copy link
Contributor Author

steweg commented Mar 29, 2024

Hi,

libyang-python only supports the master branch of C libyang (currently 2.x).

The lydevel check is only meant for informative purposes.

libyang-python/tox.ini

Lines 18 to 20 in f09ed11

[testenv:lydevel]
setenv =
LIBYANG_BRANCH=devel

If it fails (currently it should fail because libyang 3.x is under development) it is not a problem.

Could you remove all references to libyang 3 which was not released yet and only focus on the enhancements that you require?

Thank you.

Done

@steweg
data: add add_defaults module option
fc8cb79 
This patch adds ability for user to restrict adding off implicit default
values based on specified module

Signed-off-by: Stefan Gula <steweg@gmail.com>
@steweg steweg force-pushed the feature/add_defaults_module_option branch from 5ce7f2d to fc8cb79 Compare April 6, 2024 10:30
@steweg steweg requested a review from rjarry May 9, 2024 10:47
@samuel-gauthier
Copy link
Collaborator

Pushed with a few changes.

@steweg steweg deleted the feature/add_defaults_module_option branch August 3, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjarry rjarry Awaiting requested review from rjarry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steweg @samuel-gauthier @rjarry