Skip to content

Conversation

@SiskaPavel
Copy link
Collaborator

@SiskaPavel SiskaPavel commented Sep 30, 2025

Summary

Change c++ standard from c++20 to c++23 to support new features.


✅ Checks

  • Relevant documentation was updated (if needed)
  • CI pipeline passes (build, tests, lint, static analysis)
  • New code follows clang-tidy rules
  • The change is clearly related to a specific issue / requirement
  • Documentation (e.g. Doxygen) is updated if needed
  • The PR is rebased on the latest master
  • No unrelated changes are included

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the C++ standard from C++20 to C++23 to enable the use of newer language features. The changes update both the CMake configuration and RPM package specifications to ensure consistent C++23 support across all build environments.

  • Updates CMAKE_CXX_STANDARD from 20 to 23 in the main build configuration
  • Simplifies GCC toolset requirements in RPM specs by consolidating version checks
  • Removes redundant GCC version specifications for RHEL 9+ systems

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
CMakeLists.txt Updates C++ standard requirement from C++20 to C++23
pkg/rpm/ipfixprobe.spec.in Consolidates GCC toolset requirements using unified version check
pkg/rpm/ipfixprobe-nemea.spec.in Consolidates GCC toolset requirements using unified version check
pkg/rpm/ipfixprobe-msec.spec.in Consolidates GCC toolset requirements using unified version check

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SiskaPavel SiskaPavel force-pushed the update-to-c++23 branch 3 times, most recently from 43e346c to 0a0e7f3 Compare September 30, 2025 21:04
@SiskaPavel SiskaPavel changed the base branch from master to ci-change-os-to-ol10 September 30, 2025 21:04
Base automatically changed from ci-change-os-to-ol10 to master October 1, 2025 08:21
Pavel Siska added 2 commits October 1, 2025 10:31
Switch project standard from C++20 to C++23, requiring newer GCC.
Updated spec file to reflect correct gcc-c++ version.
@SiskaPavel SiskaPavel merged commit 5fdf850 into master Oct 1, 2025
8 checks passed
@SiskaPavel SiskaPavel deleted the update-to-c++23 branch October 1, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants