Conversation
144781a to
66d2503
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the C++ standard from C++20 to C++23 to enable the use of newer language features. The changes update both the CMake configuration and RPM package specifications to ensure consistent C++23 support across all build environments.
- Updates CMAKE_CXX_STANDARD from 20 to 23 in the main build configuration
- Simplifies GCC toolset requirements in RPM specs by consolidating version checks
- Removes redundant GCC version specifications for RHEL 9+ systems
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| CMakeLists.txt | Updates C++ standard requirement from C++20 to C++23 |
| pkg/rpm/ipfixprobe.spec.in | Consolidates GCC toolset requirements using unified version check |
| pkg/rpm/ipfixprobe-nemea.spec.in | Consolidates GCC toolset requirements using unified version check |
| pkg/rpm/ipfixprobe-msec.spec.in | Consolidates GCC toolset requirements using unified version check |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
43e346c to
0a0e7f3
Compare
hynekkar
approved these changes
Oct 1, 2025
added 2 commits
October 1, 2025 10:31
Switch project standard from C++20 to C++23, requiring newer GCC. Updated spec file to reflect correct gcc-c++ version.
0a0e7f3 to
f120286
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change c++ standard from c++20 to c++23 to support new features.
✅ Checks
master