Skip to content

NfbPlugin: use NUMA preferred policy instead of strict binding #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SiskaPavel merged 1 commit into from
Jul 31, 2025
Merged

NfbPlugin: use NUMA preferred policy instead of strict binding #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/plugins/input/nfb/src/ndpReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,21 +60,19 @@ int NdpReader::init_interface(const std::string& interface)
return 1;
}

struct bitmask* bits = nullptr;
int node_id;
rx_handle = ndp_open_rx_queue(dev_handle, channel);
if (!rx_handle) {
error_msg = std::string() + "error opening NDP queue of NFB device";
return 1;
}
if (((node_id = ndp_queue_get_numa_node(rx_handle)) >= 0)
&& // OPTIONAL: bind thread to correct NUMA node
((bits = numa_allocate_nodemask()) != nullptr)) {
(void) numa_bitmask_setbit(bits, node_id);
numa_bind(bits);
numa_free_nodemask(bits);
if ((node_id = ndp_queue_get_numa_node(rx_handle)) >= 0) {
// allow memory to be allocated on other nodes if preferred is unavailable
constexpr int PREFERRED_NODE_POLICY = 0;
numa_set_bind_policy(PREFERRED_NODE_POLICY);
numa_set_preferred(node_id);
} else {
error_msg = std::string() + "warning - NUMA node binding failed\n";
error_msg = "warning - NUMA node detection failed\n";
return 1;
}
if (ndp_queue_start(rx_handle)) { // start capturing data from NDP queue
Expand Down