Skip to content

TCP input: fix memory access issue #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sedmicha merged 1 commit into from
Mar 19, 2025
Merged

TCP input: fix memory access issue #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/plugins/input/tcp/src/Acceptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,10 @@ void Acceptor::add_address(IpAddress &adr, uint16_t port, bool ipv6_only) {
}

UniqueFd Acceptor::bind_address(IpAddress &addr, uint16_t port, bool ipv6_only) {
sockaddr saddr{};
auto v4 = reinterpret_cast<sockaddr_in *>(&saddr);
auto v6 = reinterpret_cast<sockaddr_in6 *>(&saddr);
sockaddr_storage saddr_storage{};
auto *saddr = reinterpret_cast<sockaddr *>(&saddr_storage);
auto *v4 = reinterpret_cast<sockaddr_in *>(&saddr_storage);
auto *v6 = reinterpret_cast<sockaddr_in6 *>(&saddr_storage);
size_t addr_len;

if (addr.version == IpVersion::IP4) {
Expand All @@ -94,7 +95,7 @@ UniqueFd Acceptor::bind_address(IpAddress &addr, uint16_t port, bool ipv6_only)

const char *err_str;

UniqueFd sd(socket(saddr.sa_family, SOCK_STREAM, 0));
UniqueFd sd(socket(saddr->sa_family, SOCK_STREAM, 0));
if (!sd) {
ipx_strerror(errno, err_str);
throw std::runtime_error("Failed to create socket: " + std::string(err_str));
Expand Down Expand Up @@ -128,7 +129,7 @@ UniqueFd Acceptor::bind_address(IpAddress &addr, uint16_t port, bool ipv6_only)
std::array<char, INET6_ADDRSTRLEN> addr_str{};
inet_ntop(static_cast<int>(addr.version), &addr.v6, addr_str.begin(), INET6_ADDRSTRLEN);

if (bind(sd.get(), &saddr, addr_len) == -1) {
if (bind(sd.get(), saddr, addr_len) == -1) {
ipx_strerror(errno, err_str);
throw std::runtime_error(
"Failed to bind to socket (local IP: "
Expand Down