Add FreeBSD into CI, fix minor FreeBSD build issues #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seemed to mostly work because libfds depends on Lz4 and so we would mostly find Lz4.h in the default system include path on Linux. On FreeBSD though, Lz4.h is in a path that is not a part of the includes that CMake would use by default, which revealed this issue.
Could not compile tests on FreeBSD otherwise.
sedmicha
force-pushed
the
github-actions-freebsd
branch
3 times, most recently
from
8577c17 to
ccaa439
Compare
sedmicha
force-pushed
the
github-actions-freebsd
branch
from
ccaa439 to
099bc27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107
Having FreeBSD as a part of our CI should also prevent similiar issues in the future