Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to incorporate into ESCOMP/CTSM branch master #1

Open
wants to merge 5 commits into
base: clm_tag_release-clm5.0.25
Choose a base branch
from

Conversation

lizziel
Copy link

@lizziel lizziel commented Aug 27, 2021

This PR is not meant for a real merge. It is simply to easily display the changes made by @fritzt in CESM-GC/CTSM:CESM-GC_dev2 relative to ESCOMP/CTSM:release-clm5.0.25. That base version is old and the changes must be incorporated into the latest release of ESCOMP/CTSM:master. Unfortunately only one of the files of the eight that were modified for the updates exists in ESCOMP/CTSM:master, and the context of the modification in that file is no longer in the code. Work to incorporate the changes will therefore take some investigation of how the CTSM code changed. This PR will help facilitate a dialogue about it.

See also the original PR to merge into the upstream: ESCOMP#1377.

The original description of the changes from @fritzt is as follows:

I have been working on implementing the GEOS-Chem (version 13.0.0) chemistry module in CESM2.1.1. This new option is designated as CESM2-GC. The implementation of GEOS-Chem chemistry inside CESM2 aims to provide an additional chemistry option alongside CAM-Chem.

This is the second PR out of three (CAM, CLM, cime). The main PR can be found at ESCOMP/CAM#378

Description of changes
This PR focuses on passing land types and leaf area indices (LAI) from CLM to CAM through the coupler. I followed the same workflow as what is done for albedo. The land types and LAI are required in CAM to let GEOS-Chem compute its own dry deposition velocities.

Specific notes
Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #): None

Are answers expected to change (and if so in what way)?
No, this PR introduces changes that only aim to pass information from CLM to CAM.

Any User Interface Changes (namelist or namelist defaults changes)?
No.

Testing performed, if any:
I was able to output land types and LAI as archived by CAM.

(1) This commit allows CLM to export land types to CAM. This allows
    GEOS-Chem to compute dry deposition velocities.
(1) This means that all patch indices will be shifted by 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants