-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new module lfi_detector #1563
Conversation
Thanks for the PR - I have added some minor comments but overall the pull request is very good! |
Thanks for the review, I will start working on the changes |
I have implemented the changes. Please let me know if anything else is needed. |
I have changed the wordlist. Please see if it's all good now. |
/etc/hostname.ce3 | ||
/etc/hostname.dcelx0 | ||
/etc/hostname.dcelx1 | ||
/etc/hostname.dcelx2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may remove the files we can't automatically detect, such as /etc/hostname, to make the scanning faster
Of course it's only about increasing the speed, so if you remove most of them, not all, it'll be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, is it possible to find a shorter payload list, e.g. <100? IMO 1000 * number of parameters to test is quite a big number of requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, that many payloads would put an unnecessary load on the target. I will modify the wordlist to remove the redundant payloads.
I have decreased the wordlist size to This should hopefully not put a lot of burden on a target that we scan. |
Thanks again for your contribution ❤️ |
Resolves #247
Description
Implements a new module
lfi_detector
Progress
get_links_and_resources_on_same_domain
to get links from the given urlfile
,page
,load
)http://{url}?file={payload1}&page={payload1}&load={payload1}
root:x
from/etc/passwd
)I am using sql_injection_detector.py as a reference for making this
Please let me know what changes are needed.