[Bug]: Correct the date logic for the population of the #dimPeople temp table

[lizbrunet]

File Specification Number and Name

None

What Happened?

8133

In all of the Student related migration stored procedures that migrate to the RDS we have logic that populates a temp table with data from rds.DimPeople. The where clause that uses date logic needs to have an isnull() added to the first condition.
where ((RecordStartDateTime <= @SYStartDate and RecordEndDateTime > @SYStartDate)
or (RecordStartDateTime > @SYStartDate and isnull(RecordEndDateTime, @SYEndDate) <= @SYEndDate))

Acceptance Criteria
• Current Behavior: There are date combinations that could slip through the current logic
• Expected Behavior: Capture all appropriate date combinations to include all possible students
• OSC Ticket: N/A
Documentation
• Release Notes: Refined the date logic that populates the #dimPeople temp table in all the Staging-to-FactK12StudentCount_* stored procedures and the standalone stored procedures for Assessment and Discipline
• Other GitBook Documentation: N/A
• ETL Checklist Impact: N/A
Testing
• Requires updating of Test Case(s) or Create Test Case if it doesn't exist
• Create appropriate test data in Hydrate
• Include a screenshot of the corrected file to confirm test results.

Steps to Reproduce

No response

Version

No response

Logs or Error Output

Priority

Medium

Code of Conduct

• I agree to follow the Code of Conduct.