Cannot merge two specific orgs on Stage or Prod

[bofstein]

I was trying to merge med.unc.edu into unc.edu on Stage to test it out before doing it on production in response to a ticket (waiting on final confirmation from them), but I got a 400 error. Other orgs are still able to be merged, unsure what is different about this one (large size?)

I can analyze them and see the information compared:

But get a 500 error when I click the Merge Records button:

Other orgs are still able to be merged, just not that set:

[bofstein]

I tried a couple other smaller ones and they worked. I then tried to find a large one - Harvard University into Harvard University (harvard.edu) - and that also did not work, same 500 error. Still doesn't mean its necessarily about size just a note.

[bofstein]

Experience is the same on Prod trying to merge these institutions

[briri]

2 part issue here.

Bad data:
There are 133 records in the orgs table with a NULL links field. This field requires a value and should be defaulted to {"org":[]}. The merge logic detects that the "winner" of the merge has an empty links field ({"org":[]}) so should be assigned the value from the other org (NULL). When the save happens the validation fails because the links field cannot be NULL.

Bug:
This bug was introduced 3 years ago! But has only just surfaced due to this edge case with the data.

The app/validators/org_links_validator.rb had a bug in it: record.errors.add(:links, format(_('A key "org" is expected for links hash'), key: k)) but k is not defined. This line is executed when the links field changes.

Fix
Once I patched the bug to the validator code, the UI displayed a proper message about being unable to complete the merge due to an invalid Org record. I will submit a PR for this patch.

When I ran a query in the DB to change that NULL links field to {"org":[]}, the merge succeeded. I have since run a query to update all 133 records with a NULL links field. All of the records were created on 06/25/2020. They are a mix of ROR and custom user created records. It is unclear if the links field was NULL at the time of creation or some other process set them to that state later on.

[briri]

Submitted same code change to the DMPRoadmap repo in PR #3480

[bofstein]

Thanks @briri ! Was the DB updated on stage, prod, or both? Can I now merge the requested orgs, or were those done already?

[briri]

the DB was updated in both prod and stage. I have already merged the UNC orgs from your original screenshot.

[bofstein]

Wonderful, thanks so much