Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case for preloaded libraries #6111

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Case for preloaded libraries #6111

merged 1 commit into from
Jul 11, 2023

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Jul 11, 2023 •
edited
Loading

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • Fix casing for some preloaded libraries in our PostgreSQL databse

Additional Information

  • These case changes may have been causing database restarts each time they're updated.
  • Terraform may be restarting the database without asking since it's designed to be hands-off. This is a weird case with a documentation gap. This is not clear based on what's in the azurerm provider.

Testing

  • How should reviewers verify this PR?

Checklist for Primary Reviewer

Infrastructure

  • Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Security

  • Changes with security implications have been approved by a security engineer (changes to authentication, encryption, handling of PII, etc.)
  • Any dependencies introduced have been vetted and discussed

Cloud

  • Oncall has been notified if this change is going in after-hours
  • If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

Documentation

  • Any changes to the startup configuration have been documented in the README

@alismx alismx changed the title update case for preloaded libraries Case for preloaded libraries Jul 11, 2023
@alismx alismx marked this pull request as ready for review July 11, 2023 17:42
rin-skylight
rin-skylight approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@rin-skylight rin-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results of terraform plan show that this resolves the capitalization discrepancy. Thank you for the quick fix!

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alismx alismx requested review from emyl3 and nathancrtr July 11, 2023 17:51
@alismx alismx merged commit 68d9b84 into main Jul 11, 2023
31 checks passed
@alismx alismx deleted the alis/db_libs branch July 11, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobanL BobanL BobanL approved these changes

@rin-skylight rin-skylight rin-skylight approved these changes

@zdeveloper zdeveloper Awaiting requested review from zdeveloper

@mehansen mehansen Awaiting requested review from mehansen

@DanielSass DanielSass Awaiting requested review from DanielSass

@emyl3 emyl3 Awaiting requested review from emyl3

@nathancrtr nathancrtr Awaiting requested review from nathancrtr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alismx @BobanL @rin-skylight