improve accessibility to support more/less buttons #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pages/support.html
Outdated
| @@ -197,10 +198,14 @@ <h2>Get in touch</h2> | |||
| bodyElement.classList.add('expanded'); | |||
| animateCSS(link, 'fadeInDown'); | |||
| footerText.textContent = 'Less'; | |||
| footerText.setAttribute("aria-label", "see less helpful links") | |||
There was a problem hiding this comment.
is there a way to pass the category to this method so it reads 'see more account management related links', 'see more testing related links'.
Also the copy of see less helpful links sounds odd as I thought it was offered to see some not so helpful links LOL.
There was a problem hiding this comment.
Done! honestly I dont know why we even have the more/less link, we dont have that many links anyway, might as well always show it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Background Info
Changes Proposed
Screenshots / Demos
deployed on dev6
Checklist for Author and Reviewer
Design
test,dev, orpentestand smoke-tested by both the engineering and design teamsContent
Support
Testing