APP-228 - Set up report execution service within Docker Compose #3007
Conversation
JordanGuinn
requested review from
emyl3 and
mcmcgrath13
and removed request for
a team
docker-compose.yml
Outdated
|
|
||
| report-execution-api: | ||
| build: | ||
| context: ./ |
There was a problem hiding this comment.
(q, nb): why the context of the whole app vs the dockerfile's root?
There was a problem hiding this comment.
No particular reason outside of following the pattern of the other services defined here - happy to update though!
There was a problem hiding this comment.
does it work with the smaller context? seems like a smaller context would be better, but I also like uniformity... 🤔
There was a problem hiding this comment.
It does!! I do like the idea of limiting the scope of the service to just the app directory itself, now that I see it - will update for now
| ports: | ||
| - "8000:8000" | ||
|
|
||
| report-execution: |
There was a problem hiding this comment.
(❓, nb) Do we want to add this new service to the cdc-sandbox/build_modernization.sh script?
emyl3
left a comment
emyl3
left a comment
There was a problem hiding this comment.
Left one non-blocking question! Thank you, Jordan!! 🙌
3 participants
Description
This PR makes updates the
Dockerfileof the newly established report execution service and adds said service to the repo-leveldocker-compose.yml, so that it can be easily spun up during local development.Tickets
Checklist before requesting a review