Conversation
|
What do you think about changing the function, |
Only worry I have there is if that causes issues with other stored procedures that call that function. And what would it look like to test and confirm that it wouldn't cause issues. |
@eliSkylight this is a good point, if we change the functionality at the function level, we'll likely need to run data compare again to make sure there aren't any regressions. Your solution is probably the best for now. If we see a pattern develop after a couple of these NULL fixes, maybe we should revisit our strategy. |
hawley-skylight
left a comment
There was a problem hiding this comment.
I agree with the suggestion that fn_get_value_by_cvg is the better place to put this. However, I am fine with revisiting this later.
Notes
This PR adds a fallback logic to the
sp_investigation_eventstored procedure to copy MasterETL mapping of codes in theNBS_SRTE.CODE_VALUE_GENERALtable. This change removes the current value ofNULLin theINIT_FUP_INITIAL_FOLL_UPinRDB_MODERN.D_CASE_MANAGEMENTfor unmapped codes.This does not effect codes that are already mapped successfully.
JIRA
Jira Ticket: APP-295
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle buildpass in your local?gradle buildlogs attached?Result Screenshot
Gradle
buildlogs