Migrate stored procedures from ODSE to RDB/RDB_Modern#675
Merged
Conversation
…scripts for ease of understanding. Only create liquibase user in database initialization
mpeels
requested review from
eliSkylight,
ericbuckley,
hawley-skylight,
mehansen and
nullflux
ericbuckley
reviewed
Feb 19, 2026
Contributor
ericbuckley
left a comment
ericbuckley
left a comment
There was a problem hiding this comment.
It looks like there are still quite a few of job_flow_log package name references to "NBS_ODSE."
...001-master/01_onboarding_scripts_user_creation/002-user-kafka_sync_connector_service_rdb.sql
Show resolved
Hide resolved
...rces/db/001-master/01_onboarding_scripts_user_creation/008-user-organization_service_rdb.sql
Show resolved
Hide resolved
liquibase-service/src/main/resources/db/005-rdb_modern/routines/067-sp_auth_user_event-001.sql
Outdated
Show resolved
Hide resolved
liquibase-service/src/main/resources/db/005-rdb_modern/routines/067-sp_auth_user_event-001.sql
Outdated
Show resolved
Hide resolved
liquibase-service/src/main/resources/db/005-rdb_modern/routines/068-sp_place_event-001.sql
Outdated
Show resolved
Hide resolved
liquibase-service/src/main/resources/db/005-rdb_modern/routines/068-sp_place_event-001.sql
Outdated
Show resolved
Hide resolved
liquibase-service/src/main/resources/db/005-rdb_modern/routines/068-sp_place_event-001.sql
Outdated
Show resolved
Hide resolved
...base-service/src/main/resources/db/005-rdb_modern/routines/057-sp_ldf_provider_event-001.sql
Outdated
Show resolved
Hide resolved
mehansen
reviewed
Feb 19, 2026
mehansen
reviewed
Feb 20, 2026
...esources/db/001-master/01_onboarding_scripts_user_creation/001-user-debezium_service_rdb.sql
Show resolved
Hide resolved
mehansen
reviewed
Feb 20, 2026
...s/db/001-master/01_onboarding_scripts_user_creation/003-user-post_processing_service_rdb.sql
Outdated
Show resolved
Hide resolved
mehansen
reviewed
Feb 21, 2026
Contributor
mehansen
left a comment
mehansen
left a comment
There was a problem hiding this comment.
everything else lgtm!
I agree the organization of the user creation and permissions is easier to follow this way
...esources/db/001-master/01_onboarding_scripts_user_creation/001-user-debezium_service_rdb.sql
Outdated
Show resolved
Hide resolved
mehansen
approved these changes
Feb 23, 2026
Contributor
mehansen
left a comment
mehansen
left a comment
There was a problem hiding this comment.
thanks for walking us through this!
ericbuckley
approved these changes
Feb 24, 2026
Contributor
ericbuckley
left a comment
ericbuckley
left a comment
There was a problem hiding this comment.
looks good, thanks @mpeels
hawley-skylight
approved these changes
Feb 24, 2026
Contributor
hawley-skylight
left a comment
hawley-skylight
left a comment
There was a problem hiding this comment.
looks good. thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
Notes
Prevents RTR from writing to the
RDB.job_flow_logwhen configured to useRDB_Modern.This is done by migrating the stored procedures listed below from
NBS_ODSEto the configured RDB database and removing hard coded references toRDB.job_flow_log. This migration also required updating the permissions granted for the various RTR users. While adjusting these permissions, user creation scripts were consolidated.