Navigation bar changes #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyjaywilson
pushed a commit
that referenced
this pull request
Jun 6, 2022
* Changed padding and such to constants * Putting in more constants * Removing commented out code * Change views * COF-37: Adds bean type to database and ability to choose the type (#25) * Adds type to model * Added picker to the new/edit coffee view * Adds icons and way to see the difference * Adds filter picker * Updates versuib * COF-43 allow user to type in notes (#27) * Cof 44 add textfield to new and edit view (#26) * COF-41: does not show option to rate * Adds notes editor * Adds note header * Refactored views to use observable objects (#29) * Closes COF-42 adds swiftlint and clears errors * Viewmodel for beanrow added * Adding tests * Better XCTAssert used * Renames viewmodel to use oo * Adds custom swiftlint file * Add oo for new bean view * COF-30 create a whats new view (#30) * Added view * Adds logic to present new view on launch * Adds release notes to about view * COF-14 allow a bean card to be shared via image (#32) * Adds views to make share possible * Changes view a bit * Empties image array * Added in scrollview * Adds share view * Style changes (#33) * Uses the colors given by Jeremie * Changes opacity on the foreground color for the watermark * Navigation bar changes (#34) * adds animation to transition * Adjusts paywall * Changes coffee list title to use the native navigation view * Changes about navigation view * fixes issue where cups incremented without successful purchase (#35) * Squashed commit of the following: commit e6ab420 Author: Maegan Wilson <maegan@maeganwilson.com> Date: Sat Apr 16 16:04:32 2022 -0500 changes sf symbols all to outline commit b30ba67 Author: Maegan Wilson <maegan@maeganwilson.com> Date: Sat Apr 16 16:01:11 2022 -0500 Changes about navigation view commit 1d54f2f Author: Maegan Wilson <maegan@maeganwilson.com> Date: Sat Apr 16 15:36:35 2022 -0500 Changes coffee list title to use the native navigation view commit 8f1ecfd Author: Maegan Wilson <maegan@maeganwilson.com> Date: Fri Apr 15 13:06:10 2022 -0500 Adjusts paywall commit 2277814 Author: Maegan Wilson <maegan@maeganwilson.com> Date: Fri Apr 15 09:12:32 2022 -0500 adds animation to transition * COF-56 coffee image needs to be top leading (#36) * Fixes image layout and not all notes showing in previw * Adds border around image * COF-55 shared image has a black border (#37) * Fixes image layout and not all notes showing in previw * Adds border around image * Fix: Removes offset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements navigation view