fix: Improve error messages for missing build artifacts - #947
Merged
Conversation
cfsmp3
requested review from
canihavesomecoffee and
thealphadollar
as code owners
December 23, 2025 13:39
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
==========================================
+ Coverage 86.88% 87.02% +0.13%
==========================================
Files 35 35
Lines 3759 3791 +32
Branches 767 776 +9
==========================================
+ Hits 3266 3299 +33
+ Misses 355 354 -1
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cfsmp3
force-pushed
the
fix/improve-artifact-error-messages
branch
2 times, most recently
from
December 23, 2025 20:01
829df8c to
90c7d6a
Compare
Add _diagnose_missing_artifact function that checks workflow run status to provide specific error messages: - Build still in progress: tells user to wait and retry - Build failed: directs user to check GitHub Actions logs - Artifact expired: explains artifacts are deleted after retention period - No workflow run: indicates workflow wasn't triggered or is queued This helps users understand why their test couldn't start and what action to take. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cfsmp3
force-pushed
the
fix/improve-artifact-error-messages
branch
from
December 23, 2025 20:12
90c7d6a to
91aa24b
Compare
|
canihavesomecoffee
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
When a test fails due to missing build artifacts, users previously saw only a generic "An error occurred" message with no details. This made it difficult to understand what went wrong.
Example: Test #7139 failed because the Windows build was still in progress (Windows builds take ~40 minutes, but the test tried to fetch the artifact immediately).
Changes
error_messageproperty to Test model to expose the last error message_diagnose_missing_artifact()helper that checks GitHub workflow status and provides specific error messages:Before vs After
Before: User sees generic "An error occurred - Something went wrong while the tests were running"
After: User sees specific error like "Error: Build still in progress: 'Build CCExtractor on Windows' is in_progress. Please wait for the build to complete and retry."
Test plan
🤖 Generated with Claude Code