Skip to content

Conversation

@hrideshmg
Copy link
Contributor

@hrideshmg hrideshmg commented Jul 18, 2025

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

Currently, the platform reports whether a regression is broken on master branch as well by comparing with a common column last_passed_on for both Windows and Linux. This PR splits this column into two and adds independent tracking for both.

Note: There is a database modification and these changes have not been tested

Copy link
Member

@canihavesomecoffee canihavesomecoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@canihavesomecoffee
Copy link
Member

@hrideshmg there are some failing unit tests though, can you fix them first (or adapt the code) before I merge?

@hrideshmg hrideshmg force-pushed the last_passed_improvements branch 6 times, most recently from 2be7a67 to 79e210d Compare July 20, 2025 20:26
@hrideshmg
Copy link
Contributor Author

@canihavesomecoffee Should be fine now, check failures are due to codecov

@canihavesomecoffee canihavesomecoffee force-pushed the last_passed_improvements branch from 79e210d to 11aa5e3 Compare July 22, 2025 13:19
@canihavesomecoffee canihavesomecoffee merged commit 71af9fb into CCExtractor:master Jul 22, 2025
1 of 5 checks passed
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants