Skip to content

Conversation

@hrideshmg
Copy link
Contributor

@hrideshmg hrideshmg commented Mar 18, 2025

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

Closes #924

As discussed on Zulip the tests are currently broken due to an inconsistency with the Tesseract versions caused by the sample platform still using Ubuntu 22.04.

This PR aims to migrate the provisioned test runners to Ubuntu 24.04 to fix this bug as well as ensure future compatibility. All changes have been tested on a deployed fork of the project.

Notable Changes

  • Updated the mono install step in the startup script to the updated versions from their site. Main motivation for this is that usage of apt-key is deprecated.
  • libtesseract-dev no longer bundles the trained data for english, so it has to be installed separately.

Migration Guide

  • config.py in the root folder will have to be modified to the following:
LINUX_INSTANCE_FAMILY_NAME = "ubuntu-minimal-2404-lts-amd64"

@hrideshmg hrideshmg changed the title [FEATUREmigrate to Ubuntu 24.04 [Improvement] migrate to Ubuntu 24.04 Mar 18, 2025
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (4e7b2ea) to head (7c60c6c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #925   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files          35       35           
  Lines        3699     3699           
  Branches      759      759           
=======================================
  Hits         3215     3215           
  Misses        348      348           
  Partials      136      136           
Flag Coverage Δ
unittests 86.91% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@canihavesomecoffee canihavesomecoffee merged commit 19052be into CCExtractor:master Mar 18, 2025
7 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux tests are currently broken

2 participants