Team response phase: cannot respond to bug reports

[damithc]

I'm getting this error when I respond to a bug report by a tester

To reproduce, join https://github.com/CATcher-testbed (invitation sent to devs already) and choose CS2103 Tutors as the session when you login to CATcher. Team response phase is already open.

[Eclipse-Dominator]

The issue is due to an unrenamed variable for responseTag which leads to an undefined attribute

    this.newTeamResponseForm = this.formBuilder.group({
      description: [''],
      severity: [this.issue.severity, Validators.required],
      type: [this.issue.type, Validators.required],
      response: [this.issue.response, Validators.required],
      assignees: [this.issue.assignees.map((a) => a.toLowerCase())],
      duplicated: [false],
      duplicateOf: ['']
    });

  get responseTag() {
    return this.newTeamResponseForm.get('responseTag');
  }

when newTeamResponseForm's responseTag property is renamed to response

[damithc]

Thanks for the quick investigation, @Eclipse-Dominator
CATcher devs, can we fix it quickly?

[Eclipse-Dominator]

Yes, I am making the PR now.

[cheehongw]

Similar class of errors when checking the A Duplicate Of checkbox when creating a new team response to bug reports.

I'm adding my findings here since I was testing out the PR by @Eclipse-Dominator and realized these errors are related to this issue.

Clicking the checkbox triggers 2 errors that happen in rapid succession:

1. Cannot read properties of null (reading setValidators)
2. Cannot read properties of null (reading setValue)

First error happens in line 71/74 when clicking the checkbox sets this.duplicated to true, which triggers the subscription here

CATcher/src/app/shared/view-issue/new-team-response/new-team-response.component.ts

Lines 68 to 78 in b333d59

	this.duplicated.valueChanges.subscribe((checked) => {
	if (checked) {
	this.duplicateOf.setValidators(Validators.required);
	this.responseTag.setValidators(null);
	} else {
	this.duplicateOf.setValidators(null);
	this.responseTag.setValidators(Validators.required);
	}
	this.duplicateOf.updateValueAndValidity();
	this.responseTag.updateValueAndValidity();
	});

Second error happens in line 187 when clicking the checkbox also calls this function

CATcher/src/app/shared/view-issue/new-team-response/new-team-response.component.ts

Lines 185 to 194 in b333d59

	handleChangeOfDuplicateCheckbox(event: MatCheckboxChange) {
	if (event.checked) {
	this.responseTag.setValue('');
	this.assignees.setValue([]);
	this.responseTag.markAsUntouched();
	} else {
	this.duplicateOf.setValue('');
	this.duplicateOf.markAsUntouched();
	}
	}