379 updated branch with all GW changes #580
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rkutteh I don't know if you are still around, but I have created this branch that is up-to-date with the main branch of CABLE. It's an update from your branch bringing in the same changes but omitting anything that has been already added to main. |
ccarouge
changed the title
@ccarouge Still around..., thanks for the update and good to see that it is all progressing well! |
Co-authored-by: Sean Bryan <39685865+SeanBryan51@users.noreply.github.com>
ccarouge
force-pushed
the
379-updated-GW-branch
branch
from
56fd39d to
c8204aa
Compare
ccarouge
force-pushed
the
379-updated-GW-branch
branch
from
c8204aa to
67f74b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
This is to replace #411 with a manually rebased branch for the GW work. This branch also does not include changes that have already be included in the main branch, in particular the modifications for the Princeton met forcings. The intention is for this branch to be rebased on main regularly to help keep track of changes. We will also include some of the modifications from this branch individually in other branches.
Type of change
Please delete options that are not relevant.
Checklist
Testing
Following the manual rebase, I have run benchcab on 42 sites with the GW scheme on comparing to the main branch and the original branch for PR #411. The analyses show that although the results are not bit-wise identical between the 2 GW branches, they are statistically identical giving confidence the rebasing happened correctly.
Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line.
Are the changes non bitwise-compatible with the main branch because of a bug fix or a feature being newly implemented or improved? If yes, add the link to the modelevaluation.org analysis versus the main branch or equivalent results below this line.
Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--580.org.readthedocs.build/en/580/