Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust plumbing to USE cable_surface_types offline #446

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

adjust plumbing to USE cable_surface_types offline #446

wants to merge 4 commits into from

Conversation

JhanSrbinovsky
Copy link
Collaborator

@JhanSrbinovsky JhanSrbinovsky commented Oct 30, 2024 •
edited by github-actions bot
Loading

CABLE

The same module name can indeed be USEd as there are seperate versions picked up by coupled/offline apps. However some additional plumbing needs to be tweaked offline.

Please see issue for further details:
Fixes #436

Type of change

Checklist

  • [X ] The new content is accessible and located in the appropriate section.
  • [X ] I have checked that links are valid and point to the intended content.
  • [X ] I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.

📚 Documentation preview 📚: https://cable--446.org.readthedocs.build/en/446/

@JhanSrbinovsky JhanSrbinovsky linked an issue Oct 30, 2024 that may be closed by this pull request
#ifdef okay for now - but surely (for this one) we can get round the need for this by modifying the files names in the offline/coupled codebases to be the same. #436
Open
@JhanSrbinovsky
Copy link
Collaborator Author

@har917 you're tagged in the issue but perhaps here is more appropriate

@bschroeter
Update CMakeLists.txt
88503a6 
Indent issue.
@JhanSrbinovsky JhanSrbinovsky self-assigned this Nov 6, 2024
@JhanSrbinovsky JhanSrbinovsky added the priority:high High priority issues that should be included in the next release. label Nov 6, 2024
@JhanSrbinovsky JhanSrbinovsky added this to the ESM1.6 FastTrack milestone Nov 6, 2024
@JhanSrbinovsky
Merge branch 'main' into 436-ifdef-okay-for-now-but-surely-for-this-o…
1243925 
…ne-we-can-get-round-the-need-for-this-by-modifying-the-files-names-in-the-offlinecoupled-codebases-to-be-the-same
@JhanSrbinovsky
Copy link
Collaborator Author

@bschroeter can you have a look at this. The next tranche of AM3 updates will be much simpler if this does in first

@JhanSrbinovsky JhanSrbinovsky mentioned this pull request Nov 8, 2024
Open
@JhanSrbinovsky
Copy link
Collaborator Author

@bschroeter can you have a look at this. The next tranche of AM3 updates will be much simpler if this does in first

Actually to get ESM1,6 to work as well - so Labels etc will be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschroeter bschroeter Awaiting requested review from bschroeter

At least 1 approving review is required to merge this pull request.

Assignees

@JhanSrbinovsky JhanSrbinovsky

Labels
priority:high High priority issues that should be included in the next release.
Projects
None yet
Milestone
ESM1.6 FastTrack
2 participants
@JhanSrbinovsky @bschroeter