Skip to content

Review Exercise 2+5#107

Merged
AnnikaLau merged 5 commits into
revisionfrom
review_mj
Apr 5, 2024
Merged

Review Exercise 2+5#107
AnnikaLau merged 5 commits into
revisionfrom
review_mj

Conversation

@mjaehn
Copy link
Copy Markdown
Contributor

@mjaehn mjaehn commented Apr 4, 2024

No description provided.

Comment thread beginner/Exercise_2/Exercise_2.ipynb Outdated
Comment on lines +154 to +156
"# create a new branch named \"planning_day1\"\n",
"# use \"git switch -c planning_day1\" to create a new branch\n",
"# (Alternative: \"git checkout -b planning_day1\")\n"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the participants be free to use their own meaningful name for their branches?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better if they have to do this by themselves and we don't tell them everything.

Comment thread beginner/Exercise_2/Exercise_2.ipynb Outdated
Comment on lines +316 to +317
" * Branch *meaningful_branch_name_A* with modifications to *schedule_day1.txt*\n",
" * Branch *meaningful_branch_name_B* with modifications to *schedule_day2.txt*\n",
" * Branch *planning_day1* with modifications to *schedule_day1.txt*\n",
" * Branch *planning_day2* with modifications to *schedule_day2.txt*\n",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would undo this change and the commented on above

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are not here today, I have to decide and do this for you.

Comment thread beginner/Exercise_2/Exercise_2.ipynb Outdated
Comment thread beginner/Exercise_2/Exercise_2.ipynb Outdated
@AnnikaLau AnnikaLau merged commit fbf4fbc into revision Apr 5, 2024
@AnnikaLau AnnikaLau deleted the review_mj branch April 5, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants