Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 574 table as dialogue #580

Merged
merged 23 commits into from
Oct 16, 2023
Merged

Feature/issue 574 table as dialogue #580

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ab877a8
add new references as const
danieleguido Sep 28, 2023
8ff0f80
Update ArticleFigure.js
danieleguido Sep 28, 2023
5f8e0b9
Update ArticleFigure.js
danieleguido Sep 28, 2023
316d083
add various tags
danieleguido Sep 28, 2023
d9a2ebf
fix link from figure label
danieleguido Sep 29, 2023
67d6199
enable '<br/>'
danieleguido Sep 29, 2023
f77368b
rename ArticleFigure
danieleguido Sep 29, 2023
be16ea8
addd iconoir react lib
danieleguido Oct 4, 2023
48cf4c5
replace table tagged as dialog only if markdown
danieleguido Oct 4, 2023
e82a2d6
add class css when cells are tagged as "dialog"
danieleguido Oct 4, 2023
d9ba627
add method getPrefix() to get the prefix without the "-" (nicer on css)
danieleguido Oct 4, 2023
3aa1c78
Update ArticleCellFigure.scss
danieleguido Oct 4, 2023
20cbc42
add <br> variant to markdown rendering
danieleguido Oct 4, 2023
f0af58b
add different icons
danieleguido Oct 4, 2023
9a97659
use div instead of p in nested figcaption in ArticleCellFigure
danieleguido Oct 4, 2023
731a69a
forward figureRefPrefix in ArticleToc to replace isTable isFigure
danieleguido Oct 4, 2023
2ac8f30
fix missing tr
danieleguido Oct 9, 2023
bcdfb04
move replacement for td from ArticleCell to pynb logic function toget…
danieleguido Oct 9, 2023
2d9f417
refine dialog preview in the oither layer
danieleguido Oct 9, 2023
0326eb7
improve readability of ArticleCell memo
danieleguido Oct 16, 2023
95d7b06
use Mediamage instead of Image in ToC
danieleguido Oct 16, 2023
a8a6d4d
add cover in constrant prefix
danieleguido Oct 16, 2023
cbc317b
when cover, just use "cover" translation label in ArticleFigure
danieleguido Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
forward figureRefPrefix in ArticleToc to replace isTable isFigure
  • Loading branch information
@danieleguido
danieleguido committed Oct 4, 2023
commit 731a69abf11f74aaad1ec6c64bb4a8547de1cc4e
1 change: 1 addition & 0 deletions src/components/ArticleV2/ArticleToC.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ const ArticleToC = ({
: cell.isFigure
? t(cell.figure.tNLabel, { n: cell.figure.tNum })
: '(na)',
figureRefPrefix: cell.isFigure ? cell.figure.refPrefix : null,
isFigure: cell.isFigure,
isTable: cell.isTable,
isHermeneutics: cell.layer === LayerHermeneutics,
Expand Down