Skip to content

Add option to append labels instead of overwrite #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

peterjaap
Copy link
Contributor

@peterjaap peterjaap commented Apr 4, 2023

 ~/development/workspace/elgentos/hypernode-api-cli   main ±  ./hypernode-api-cli brancher:update abcm2-ephn1i49h --label="test6=test6"                
Brancher node update for abcm2-ephn1i49h requested
 ~/development/workspace/elgentos/hypernode-api-cli   main ±  ./hypernode-api-cli brancher:list abcm2                                                  
+-------+-----------------+------+----------------------------------+---------------+----------+--------------+-------------+
| Id    | Name            | Cost | Created                          | Ip            | End_time | Elapsed_time | Labels      |
+-------+-----------------+------+----------------------------------+---------------+----------+--------------+-------------+
| 16031 | abcm2-ephn1i49h | 1529 | 2023-04-03T19:27:43.654370+02:00 | 83.217.94.168 |          | 91693        | test6=test6 |
+-------+-----------------+------+----------------------------------+---------------+----------+--------------+-------------+
 ~/development/workspace/elgentos/hypernode-api-cli   main ±  ./hypernode-api-cli brancher:update abcm2-ephn1i49h --label="test5=test5" --append-labels
Brancher node update for abcm2-ephn1i49h requested
 ~/development/workspace/elgentos/hypernode-api-cli   main ±  ./hypernode-api-cli brancher:update abcm2-ephn1i49h --label="test4=test4" --append-labels
Brancher node update for abcm2-ephn1i49h requested
 ~/development/workspace/elgentos/hypernode-api-cli   main ±  ./hypernode-api-cli brancher:update abcm2-ephn1i49h --label="test3=test3"  --append-labels
Brancher node update for abcm2-ephn1i49h requested
 ~/development/workspace/elgentos/hypernode-api-cli   main ±  ./hypernode-api-cli brancher:update abcm2-ephn1i49h --label="test3=test3"  --append-labels
 ✘  ~/development/workspace/elgentos/hypernode-api-cli   main ±  ./hypernode-api-cli brancher:list abcm2                                                   
+-------+-----------------+------+----------------------------------+---------------+----------+--------------+-------------+
| Id    | Name            | Cost | Created                          | Ip            | End_time | Elapsed_time | Labels      |
+-------+-----------------+------+----------------------------------+---------------+----------+--------------+-------------+
| 16031 | abcm2-ephn1i49h | 1529 | 2023-04-03T19:27:43.654370+02:00 | 83.217.94.168 |          | 91708        | test3=test3 |
|       |                 |      |                                  |               |          |              | test4=test4 |
|       |                 |      |                                  |               |          |              | test5=test5 |
|       |                 |      |                                  |               |          |              | test6=test6 |
+-------+-----------------+------+----------------------------------+---------------+----------+--------------+-------------+

Copy link
Collaborator

@tdgroot tdgroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the approach you took with http_build_query 😄. Gonna merge, add a test for this and then release.

@tdgroot tdgroot merged commit 7a2047e into ByteInternet:master Apr 5, 2023
@peterjaap
Copy link
Contributor Author

@tdgroot credit for the http_build_query trick goes to our new best friend GPT-4 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants