-
Notifications
You must be signed in to change notification settings - Fork 9
use github fast path to check for changes before doing the git pull #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Byron what do you think? |
|
That sounds like a very good idea, please go for it! There should also be some tests that clone from GitHub already on CI, so I'd expect the code to run already. Thus I'd think not much has to be done except for maybe assuring that it doesn't break non-GitHub. For that, maybe have some unit tests around the 'is this a GitHub URL' to be sure it will work for other URLs as well, that should suffice. |
2e202d9 to
621bd78
Compare
|
r? @Byron |
|
btw, I removed the feature-flag again, thinking that we should actually never provide the option not to use the fast-path for github. Of course we might have unnecessary dependencies for non-github indexes, though |
|
Of course I can add it back and make it optional |
Byron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, thanks a lot for contributing!
621bd78 to
3bd1c11
Compare
|
And here is a new release, with |
Coming from this zulip thread, looking at:
it seems to be recommended by github to use the fast path to check if there are changes, before actually doing the git pull.
This is for just just a (working) draft PR that needs some work around errors & tests, but I wanted to check with you if the approach is fine before I invest more work.
With this change I would probably change docs.rs to check the index more often, so we see requests more often.