Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add option to signoff git commits #32

Merged
merged 1 commit into from
Oct 9, 2024
Merged

feat: Add option to signoff git commits #32

merged 1 commit into from
Oct 9, 2024

Conversation

dave-tucker
Copy link
Contributor

Adds cargo smart-release --signoff to sign off git commits.

Fixes: #31

@dave-tucker
feat: Add option to signoff git commits
32283ca 
Adds `cargo smart-release --signoff` to sign off git
commits.

Fixes: Byron#31

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Byron
Byron approved these changes Oct 9, 2024
View reviewed changes
Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great work, thank you!

@Byron Byron merged commit c498d29 into Byron:main Oct 9, 2024
13 checks passed
@Byron
Copy link
Owner

Byron commented Oct 9, 2024

By the way, on main and only on CI the new tests fail. For now I have ignored them with a note on how I think they can be fixed. gix-testtools could be used to executes a script that creates a fixture whose path can then be used for a read-only (or even a mutating) operation. Maybe there is another way to fix them as well, I didn't look into trying to understand why it fails on CI (on main) and not locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

commit signoff
2 participants
@dave-tucker @Byron