Skip to content
This repository was archived by the owner on Feb 9, 2023. It is now read-only.

Conversation

@realwind2048
Copy link

  • 일부 단말에서 소수점 연산으로 인해 throwing close 되지 않는 경우가 있어서 isInExitZone 내에 safe margin 1 px 추가

  • throwing 속도를 좀 더 잘 측정하기 위해 GestureBlackBox 추가
    최대 100개의 이동경로를 수집하고,
    100ms 내에 이동한 방향, 속도를 측정합니다

mGesturePoints.add(new GesturePoint(point, System.currentTimeMillis()));
}

private boolean getPoints() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getPoints 리면 point list가 리턴되어야 할 것 같은 느낌인데 updatePoints 같은 이름으로 바꾸는것이 어떨까요

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다

}

@Override
public String toString() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 필요한가요?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제거했습니다

Copy link

@josh-yun josh-yun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@toc2menow toc2menow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@realwind2048 realwind2048 merged commit 30313d3 into master Sep 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/pop_throw_close branch September 27, 2019 02:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants