This repository was archived by the owner on Feb 9, 2023. It is now read-only.
[CD-82] Fix pop throw close #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toc2menow
reviewed
Sep 24, 2019
| mGesturePoints.add(new GesturePoint(point, System.currentTimeMillis())); | ||
| } | ||
|
|
||
| private boolean getPoints() { |
There was a problem hiding this comment.
getPoints 리면 point list가 리턴되어야 할 것 같은 느낌인데 updatePoints 같은 이름으로 바꾸는것이 어떨까요
| } | ||
|
|
||
| @Override | ||
| public String toString() { |
This reverts commit 4f49a5a
[CD-91] Fix disappearing pop icon
toc2menow
approved these changes
Sep 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
일부 단말에서 소수점 연산으로 인해 throwing close 되지 않는 경우가 있어서 isInExitZone 내에 safe margin 1 px 추가
throwing 속도를 좀 더 잘 측정하기 위해 GestureBlackBox 추가
최대 100개의 이동경로를 수집하고,
100ms 내에 이동한 방향, 속도를 측정합니다