-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve download translation script #151
Improve download translation script #151
Conversation
Regressions introduced by d33c4da
warning for charset conversion issues error for missing binaries and ./po dir
download-translations
Outdated
# check for 'diff' program | ||
diff --version 2>/dev/null >/dev/null | ||
if [ $? -ne 0 ]; then | ||
echo "==== You must have the 'diff' program installed for this script ====" | ||
exit 1 | ||
err_msg "==== You must have the 'diff' program installed for this script ====" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with this you can actually write:
diff --version 2>/dev/null >/dev/null | err_msg "==== You must have the 'diff' program installed for this script ===="
(also below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want, we can also omit the "===="
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, reduced some lines.
thanks a lot! |
The reasons are explained in the commits, but here is a summary:
::error::some error text here
and::warning::some warning here
to include annotation when running in GitHub Actions (which is a WIP right now)