Fix TorchesAIE expansion locations

[raspersc2]

This fixes two problems on the new map TorchesAIE. I believe this PR fixes the find expansion logic without breaking any existing maps.

1. Mineral wall resources get grouped with base resources

This is tricky because the gold mineral wall has the type RICHMINERALFIELD so we can't just filter it out. However there is a flaw in the logic that currently groups resources if its < 8.5 to any other resource. Instead of doing that we can measure the distance between two cluster centers to get more accurate resource groups. Now the base resources and the gold mineral wall are seperated.

I did have to add some logic for dealing with the mineral wall, please let me know if this should be changed.

if amount > 12:
    logger.warning(f"Found resource group of size {amount}, possible mineral wall? Skipping this one.")
    continue

2. Not handling locations with two possible expansion positions

Here we can see for one resource group, there is a valid expansion position on both sides of the mineral line. For this I used linear regression to check for vespene geysers on either side of the (mineral) line. To allow support of this I had to change the data structure of self._resource_location_to_expansion_position_dict from dict[Point2, Point2] to dict[Point2, set[Point2]] so it supports the possibility a resource can belong to more then one base.

[BurnySc2]

Suggested change

	logger.warning(f"Found resource group of size {amount}, possible mineral wall? Skipping this one.")
	logger.debug(f"Found resource group of size {amount}, possible mineral wall? Skipping this one.")

I think this function was only called once at the start of the game? However, each bot playing on this map or a map with a mineral wall will receive such a loguru entry. Is this desired behavior?

[raspersc2]

Yeah, I wasn't too sure how to handle it. Should the logging behavior be removed?

[BurnySc2]

Yes, I think complete removal of logging would be even better.

[BurnySc2]

Suggested change

	def _find_expansion_location(
	self, resources: Units | list[Unit], amount: int, offsets: list[tuple]
	) -> Point2 | None:
	"""
	Finds the most suitable expansion location for resources.
	Parameters:
	resources: The list of resource entities or units near which the
	expansion location needs to be found.
	amount: The total number of resource entities or units to consider.
	offsets (list[tuple]): A list of coordinate pairs denoting position offsets to consider
	around the center of resources.
	def _find_expansion_location(
	self, resources: Units | list[Unit], amount: int, offsets: list[tuple[float, float]]
	) -> Point2:
	"""
	Finds the most suitable expansion location for resources.
	Parameters:
	resources: The list of resource entities or units near which the
	expansion location needs to be found.
	amount: The total number of resource entities or units to consider.
	offsets (list[tuple[float, float]]): A list of coordinate pairs denoting position offsets to consider
	around the center of resources.

I guess the tuples can be Point2 too and it should still work.
Also I don't see a return None so that the return type can be reduced to Point2? In the othe code calling this function, you never expect it to return None.

[raspersc2]

Good spot! Not sure why it had a None return type

[BurnySc2]

Suggested change

	def side_of_line(point):
	return point.y - slope * point.x - intercept
	def side_of_line(point: Point2) -> float:
	return point.y - slope * point.x - intercept