Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

look into failing roundtrip tests on macos #46

Open
BurntSushi opened this issue Jun 5, 2021 · 1 comment
Open

look into failing roundtrip tests on macos #46

BurntSushi opened this issue Jun 5, 2021 · 1 comment

Comments

@BurntSushi
Copy link
Owner

CI build failure: https://github.com/BurntSushi/rust-snappy/runs/2751122501?check_suite_focus=true

The failing tests are tests that check that this library generates the same compressed output as the reference Snappy C++ implementation. So a failing test here doesn't necessarily indicate a correctness issue, but that perhaps the reference implementation changed or got some improvements that we should investigate.

My next steps would probably be:

  • Compare the versions on macOS and Linux CI. Are they the same? If so, try to understand why the failures might be happening on macOS and not Linux. If they aren't the same, try reproducing the problem on Linux with the same Snappy version used on macOS.
  • Review the commit log for the reference Snappy C++ implementation and see if there are any relevant recentish changes.

For now, I've disabled running the cpp roundtrip tests on macOS in CI.

BurntSushi added a commit that referenced this issue Jun 5, 2021
Maybe macos is using a different version of the C++ reference
implementation?

Ref #46
@Icelk
Copy link

Icelk commented May 25, 2022

This also occurs on Linux x64:

rust-snappy/test ❯ cargo test --all-features

...

failures:
    tests::qc_cmpcpp
    tests::random2::cmpcpp
    tests::random3::cmpcpp
    tests::random4::cmpcpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants