Skip to content

fix: a broken symlink results in ripgrep emitting an error even if the symlink is ignored (#2552)#3354

Open
krapcys1-maker wants to merge 1 commit intoBurntSushi:masterfrom
krapcys1-maker:fix/issue-2552-20260406184904
Open

fix: a broken symlink results in ripgrep emitting an error even if the symlink is ignored (#2552)#3354
krapcys1-maker wants to merge 1 commit intoBurntSushi:masterfrom
krapcys1-maker:fix/issue-2552-20260406184904

Conversation

@krapcys1-maker
Copy link
Copy Markdown

Fixes #2552

Summary

Addresses #2552 in BurntSushi/ripgrep with a minimal, targeted change.

Problem

Copied from #2431:

What changed

  • crates/ignore/src/walk.rs

Solution

Apply focused code changes in crates/ignore/src/walk.rs to remove the reported behavior from #2552.

Why

Before: users hit the behavior described in #2552. After: behavior should follow issue expectations while keeping changes minimal and auditable.

Tests

  • cargo check --workspace
  • cargo test -p grep-printer --lib -- --nocapture

Scope

  • Changed files (1): crates/ignore/src/walk.rs
  • Root-cause gate verdict: confirmed
  • Replay stability: not_run

Validation

  • Local validation gate verdict: confirmed (risk: low).
  • Passed check in 1.1s: cargo check --workspace
  • Passed check in 1.5s: cargo test -p grep-printer --lib -- --nocapture

Limitations

Deterministic multi-replay was not executed in this run (replay_stability_status=not_run).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a broken symlink results in ripgrep emitting an error even if the symlink is ignored

2 participants