fix: a broken symlink results in ripgrep emitting an error even if the symlink is ignored (#2552)#3354
Open
krapcys1-maker wants to merge 1 commit intoBurntSushi:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2552
Summary
Addresses #2552 in BurntSushi/ripgrep with a minimal, targeted change.
Problem
Copied from #2431:
What changed
Solution
Apply focused code changes in
crates/ignore/src/walk.rsto remove the reported behavior from #2552.Why
Before: users hit the behavior described in #2552. After: behavior should follow issue expectations while keeping changes minimal and auditable.
Tests
cargo check --workspacecargo test -p grep-printer --lib -- --nocaptureScope
crates/ignore/src/walk.rsconfirmednot_runValidation
confirmed(risk:low).cargo check --workspacecargo test -p grep-printer --lib -- --nocaptureLimitations
Deterministic multi-replay was not executed in this run (
replay_stability_status=not_run).