fix: disable brace expansion in gitignore to match git behavior#3331
Open
xingzihai wants to merge 1 commit intoBurntSushi:masterfrom
Open
fix: disable brace expansion in gitignore to match git behavior#3331xingzihai wants to merge 1 commit intoBurntSushi:masterfrom
xingzihai wants to merge 1 commit intoBurntSushi:masterfrom
Conversation
Git's gitignore does not support brace expansion (e.g., {a,b} is treated
literally, not as an alternation). This commit adds a literal_braces option
to GlobBuilder and enables it in gitignore parsing, fixing patterns like
{{cookiecutter.project_name}} which were previously failing to parse.
Fixes BurntSushi#2830
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2830 by disabling brace expansion in gitignore patterns to match git behavior.\n\n## Changes\n- Disabled brace expansion in gitignore pattern matching\n\nFixes #2830