Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Makefile.inc to "make" type #2846

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add Makefile.inc to "make" type #2846

wants to merge 2 commits into from

Conversation

bad
Copy link

@bad bad commented Jun 28, 2024

The *BSD build systems make use of "Makefile.inc" a lot. Make the "make" type recognize this file by default.

The *BSD build systems make use of "Makefile.inc" a lot.  Make the "make" type recognize this file by default.
@okdana
Copy link
Contributor

okdana commented Jun 29, 2024

You might consider generalising this to Makefile.* actually. It's common to use this naming convention for alternate Makefiles, e.g. for different targets. An extreme example of this is RetroArch, but even FreeBSD has some other instances that the change in its current form wouldn't address

(If you did do it that way, i would suggest Makefile.* instead of [Mm]akefile.* because the latter seems too prone to false positives in this case)

@bad
Copy link
Author

bad commented Jul 28, 2024

Is there a reason this PR hasn't been merged yet?

@BurntSushi
Copy link
Owner

Sometimes it just takes me a while.

Otherwise I think I agree with @okdana's feedback here.

@bad
Copy link
Author

bad commented Jul 28, 2024

Thanks for the quick response.

I'm fine with @okdana's suggestion and changed the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants