-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix [home|away]_turnovers #197
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is actually reflecting the number of timeouts that a team has remaining at the end of the game.
in 2009081551, Chicago and Buffalo both called 2 first half timeouts. In the second half, Chicago called 3 timeouts and Buffalo called 1 timeout.
Thanks for stripping all of my comments new github (has to be their fault and not me not knowing how to use their system!) Chicago threw 4 interceptions and lost 1 fumble but |
That was my thought as well. 2015101103 was what I was looking at. ATL should have had 3 turnovers. Didn't find something that told me how many timeouts they had left so I could confirm what exactly 'to' was. Ended up doing a search in the DB and all turnovers were between 0 and 3. That seemed.... unlikely. |
fix game times based on meridiem
Modified version of BurntSushi#197. Fixed home_turnovers and away_turnovers mapping from timeout mapping. Added command line option to update game turnovers.
This addresses a discrepancy between the game.xxx_turnovers in the game table and the incoming JSON from nfl.com
I don't know what 'to' is, but I'm fairly certain that it is not turnovers as the data doesn't match up with the play-by-play data. The changes here make the statistical category match up with the play-by-play.
Unfortunately, the existing data is already wrong since these values are written to the db. The following code fixes up the DB.