This repository has been archived by the owner on Jun 22, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Feature/liveblog #261
Merged
Merged
Feature/liveblog #261
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e18900c
Include liveblog with thunder
tjwelde baf9593
Liveblog: use newer version for make workflow
tjwelde b38e5fa
moved liveblog_paragraphs into the distribution.
tjwelde 09ec0f5
Liveblog: install Pusher by default
tjwelde acb5359
Add Liveblog to the OptionalModules.
tjwelde b3b8c5b
sort optional modules by weight.
tjwelde 9e6f8ed
added pusher library to make workflow
tjwelde 0b48f40
required core version was missing
tjwelde f7440dd
liveblog has a dependeny to simple_gmap
tjwelde 6800c45
only use pusher as notification channel, if necessary config is set
tjwelde d003c7a
fixed phpcs issues
tjwelde cdd73a8
fix phpcs issues with project prefixing
tjwelde 64e8bc0
added readme to thunder_liveblog
tjwelde 9224066
add permissions for liveblog
tjwelde d2e254a
use for-loop for adding permissions
tjwelde 0554a29
added info about noting down cluster info
tjwelde daa9e63
update liveblog
tjwelde ba19362
Liveblog integration: replace body with paragraphs
tjwelde e5a8eca
Added testing of configuration for Live Blog integraton
mtodor c7ba264
Liveblog: resolve schema issues
tjwelde fca6096
removed thunder_liveblog from the schema check
tjwelde 050f61d
convert optional module sorting from callback to sorting function
tjwelde 72d29ad
fix index region missing
tjwelde 67c010b
hide labels for filed_paragraphs and field_embed_media
tjwelde f4bbde7
update liveblog (node-description / show pusher errors)
tjwelde c24f385
Merge branch 'develop' into feature/liveblog
chrfritsch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #Thunder Liveblog | ||
|
|
||
| This module integrates the liveblog module into Thunder. | ||
|
|
||
| It adds social media paragraphs to the liveblog post form and installs all necessary modules. |
49 changes: 49 additions & 0 deletions
49
...der_liveblog/config/install/field.field.liveblog_post.liveblog_post.field_embed_media.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| langcode: en | ||
| status: true | ||
| dependencies: | ||
| config: | ||
| - field.storage.liveblog_post.field_embed_media | ||
| - paragraphs.paragraphs_type.instagram | ||
| - paragraphs.paragraphs_type.twitter | ||
| module: | ||
| - entity_reference_revisions | ||
| - liveblog | ||
| id: liveblog_post.liveblog_post.field_embed_media | ||
| field_name: field_embed_media | ||
| entity_type: liveblog_post | ||
| bundle: liveblog_post | ||
| label: 'Embed media' | ||
| description: '' | ||
| required: false | ||
| translatable: false | ||
| default_value: { } | ||
| default_value_callback: '' | ||
| settings: | ||
| handler: 'default:paragraph' | ||
| handler_settings: | ||
| target_bundles: | ||
| instagram: instagram | ||
| twitter: twitter | ||
| target_bundles_drag_drop: | ||
| gallery: | ||
| weight: 8 | ||
| enabled: false | ||
| instagram: | ||
| enabled: true | ||
| weight: 9 | ||
| link: | ||
| weight: 10 | ||
| enabled: false | ||
| media: | ||
| weight: 11 | ||
| enabled: false | ||
| quote: | ||
| weight: 12 | ||
| enabled: false | ||
| text: | ||
| weight: 13 | ||
| enabled: false | ||
| twitter: | ||
| enabled: true | ||
| weight: 14 | ||
| field_type: entity_reference_revisions |
64 changes: 64 additions & 0 deletions
64
modules/thunder_liveblog/config/install/field.field.node.liveblog.field_paragraphs.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| langcode: en | ||
| status: true | ||
| dependencies: | ||
| config: | ||
| - field.storage.node.field_paragraphs | ||
| - node.type.liveblog | ||
| - paragraphs.paragraphs_type.gallery | ||
| - paragraphs.paragraphs_type.image | ||
| - paragraphs.paragraphs_type.instagram | ||
| - paragraphs.paragraphs_type.link | ||
| - paragraphs.paragraphs_type.quote | ||
| - paragraphs.paragraphs_type.text | ||
| - paragraphs.paragraphs_type.twitter | ||
| - paragraphs.paragraphs_type.video | ||
| module: | ||
| - entity_reference_revisions | ||
| id: node.liveblog.field_paragraphs | ||
| field_name: field_paragraphs | ||
| entity_type: node | ||
| bundle: liveblog | ||
| label: Paragraphs | ||
| description: '' | ||
| required: false | ||
| translatable: true | ||
| default_value: { } | ||
| default_value_callback: '' | ||
| settings: | ||
| handler: 'default:paragraph' | ||
| handler_settings: | ||
| target_bundles: | ||
| gallery: gallery | ||
| image: image | ||
| instagram: instagram | ||
| link: link | ||
| quote: quote | ||
| text: text | ||
| twitter: twitter | ||
| video: video | ||
| target_bundles_drag_drop: | ||
| gallery: | ||
| enabled: true | ||
| weight: 9 | ||
| image: | ||
| enabled: true | ||
| weight: 10 | ||
| instagram: | ||
| enabled: true | ||
| weight: 11 | ||
| link: | ||
| enabled: true | ||
| weight: 12 | ||
| quote: | ||
| enabled: true | ||
| weight: 13 | ||
| text: | ||
| enabled: true | ||
| weight: 14 | ||
| twitter: | ||
| enabled: true | ||
| weight: 15 | ||
| video: | ||
| enabled: true | ||
| weight: 16 | ||
| field_type: entity_reference_revisions |
20 changes: 20 additions & 0 deletions
20
modules/thunder_liveblog/config/install/field.storage.liveblog_post.field_embed_media.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| langcode: en | ||
| status: true | ||
| dependencies: | ||
| module: | ||
| - entity_reference_revisions | ||
| - liveblog | ||
| - paragraphs | ||
| id: liveblog_post.field_embed_media | ||
| field_name: field_embed_media | ||
| entity_type: liveblog_post | ||
| type: entity_reference_revisions | ||
| settings: | ||
| target_type: paragraph | ||
| module: entity_reference_revisions | ||
| locked: false | ||
| cardinality: 1 | ||
| translatable: true | ||
| indexes: { } | ||
| persist_with_no_fields: false | ||
| custom_storage: false |
36 changes: 36 additions & 0 deletions
36
modules/thunder_liveblog/config/install/rest.resource.entity.paragraph.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| langcode: en | ||
| status: true | ||
| dependencies: | ||
| module: | ||
| - hal | ||
| - paragraphs | ||
| - serialization | ||
| - user | ||
| id: entity.paragraph | ||
| plugin_id: 'entity:paragraph' | ||
| granularity: method | ||
| configuration: | ||
| GET: | ||
| supported_formats: | ||
| - hal_json | ||
| - json | ||
| supported_auth: | ||
| - cookie | ||
| POST: | ||
| supported_formats: | ||
| - hal_json | ||
| - json | ||
| supported_auth: | ||
| - cookie | ||
| DELETE: | ||
| supported_formats: | ||
| - hal_json | ||
| - json | ||
| supported_auth: | ||
| - cookie | ||
| PATCH: | ||
| supported_formats: | ||
| - hal_json | ||
| - json | ||
| supported_auth: | ||
| - cookie |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| name: 'Thunder Liveblog' | ||
| description: 'Integrates with the Paragraphs module and Thunder for media embeding' | ||
| type: module | ||
| core: 8.x | ||
| dependencies: | ||
| - entity_reference_revisions:entity_reference_revisions | ||
| - drupal:field | ||
| - drupal:link | ||
| - liveblog:liveblog | ||
| - liveblog:liveblog_pusher | ||
| - drupal:options | ||
| - paragraphs:paragraphs | ||
| - simple_gmap:simple_gmap | ||
| - drupal:text | ||
| - thunder:thunder | ||
| - thunder:thunder_paragraphs | ||
| - drupal:user | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a "Liveblog" paragraph into thunder_liveblog to make it possible to integrate a liveblog into an article
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, this wasn't planned like that, since the liveblog lazyloads, so it must be always added to the end and it should be easily possible to set the "live" flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would propose adding paragraphs to the Liveblog Content Type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or I could add an entity reference to liveblog at the end of an article. The downside of this could be that you can't easily mark your liveblogs in a special way on the frontpage, or make a view with all articles which have a liveblog.