Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ruby-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2.4.3
3 changes: 2 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ source "https://rubygems.org"
# This will help ensure the proper Jekyll version is running.
# Happy Jekylling!
gem "jekyll", "3.5.2"
gem "jekyll-analytics"

# This is the default theme for new Jekyll sites. You may change this to anything you like.
# gem "minima", "~> 2.0"
gem "minima", "~> 2.0"

# If you want to use GitHub Pages, remove the "gem "jekyll"" above and
# uncomment the line below. To upgrade, run `bundle update github-pages`.
Expand Down
36 changes: 22 additions & 14 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ GEM
addressable (2.5.2)
public_suffix (>= 2.0.2, < 4.0)
colorator (1.1.0)
ffi (1.9.18)
ffi (1.9.25)
forwardable-extended (2.6.0)
jekyll (3.5.2)
addressable (~> 2.4)
Expand All @@ -17,29 +17,36 @@ GEM
pathutil (~> 0.9)
rouge (~> 1.7)
safe_yaml (~> 1.0)
jekyll-feed (0.9.2)
jekyll-analytics (0.1.11)
jekyll-feed (0.11.0)
jekyll (~> 3.3)
jekyll-sass-converter (1.5.0)
jekyll-sass-converter (1.5.2)
sass (~> 3.4)
jekyll-watch (1.5.0)
listen (~> 3.0, < 3.1)
kramdown (1.15.0)
jekyll-seo-tag (2.5.0)
jekyll (~> 3.3)
jekyll-watch (1.5.1)
listen (~> 3.0)
kramdown (1.17.0)
liquid (4.0.0)
listen (3.0.8)
listen (3.1.5)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
ruby_dep (~> 1.2)
mercenary (0.3.6)
minima (2.1.1)
jekyll (~> 3.3)
pathutil (0.14.0)
minima (2.5.0)
jekyll (~> 3.5)
jekyll-feed (~> 0.9)
jekyll-seo-tag (~> 2.1)
pathutil (0.16.1)
forwardable-extended (~> 2.6)
public_suffix (3.0.0)
rb-fsevent (0.10.2)
public_suffix (3.0.3)
rb-fsevent (0.10.3)
rb-inotify (0.9.10)
ffi (>= 0.5.0, < 2)
rouge (1.11.1)
ruby_dep (1.5.0)
safe_yaml (1.0.4)
sass (3.5.1)
sass (3.6.0)
sass-listen (~> 4.0.0)
sass-listen (4.0.0)
rb-fsevent (~> 0.9, >= 0.9.4)
Expand All @@ -50,9 +57,10 @@ PLATFORMS

DEPENDENCIES
jekyll (= 3.5.2)
jekyll-analytics
jekyll-feed (~> 0.6)
minima (~> 2.0)
tzinfo-data

BUNDLED WITH
1.15.4
1.16.5
49 changes: 45 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,19 @@
# my-first-pull-request
Helping first time contributors learn the mechanics of submitting a pull request

## Menu
You can check the following topics that will guide you through your PR submitting process.

# Welcome
0. [Create and issue](#0-create-an-issue)
1. [Fork the repository](#1-fork-the-repository)
2. [Clone the repository](#2-clone-the-repository)
3. [Make necessary-changes](#3-make-necessary-changes)
4. [Commit with a proper commit message](#4-commit-with-a-proper-commit-message)
5. [Initiate a Pull Request](#5-initiate-a-pull-request)
6. [Signing in](#6-signing-in)
7. [Opening pull requests](#7-opening-pull-requests)

-----------

# 0. Create an issue
1. Go to [Issue section](https://github.com/sushant-j/my-first-pull-request/issues) of the repository.
Expand All @@ -17,8 +28,38 @@ Helping first time contributors learn the mechanics of submitting a pull request

# 1. Fork the repository

# 2. Make necessary changes
1. On the upper-right corner of the repo, you'll see a fork icon.
![fork icon](./images/DEMO-03.png)
2. Click on the fork icon, and wait until the forking process is finished.
3. You're done! You can now fork the repo using your github user directly.


# 2. Clone the repository
-- you will get a link out there,clone it by copy the link from dialog box.


# 3. Make necessary changes.


# 4. Commit with a proper commit message.
1. git commit filename -m"message".

# 5. Initiate a Pull Request
1. Push the changes to branch other than master.
-- you can change branch by git checkout branchname(<b>Do not make changes in master branch.NEVER</b>).
-- if you have not created branch then you can create it by git branch branchname.
-- git push -u origin issue_name.


# 6. Signing in
if you are pushing request for the 1st time you need to sign in with your username and password.

# 7. Opening pull requests:
If you are hoping to contribute back to the original repository, you can send a request to the original author to pull your fork into their repository by submitting a pull request.

Congrats!
--Now its on author to merge changes you made or not.
--if any suggestions are made,correct it and repeat step 3 and 4 again.<b>Cheers</b>

# 3. Commit with a proper commit message.

# 4. Initiate a Pull Request
15 changes: 11 additions & 4 deletions _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,22 @@ email: sushantj@sminq.com
description: > # this means to ignore newlines until "baseurl:"
Welcome! This project exists for beginners to learn the mechanics of making a Pull Request, or PR.
baseurl: "" # the subpath of your site, e.g. /blog
url: "https://first-pull-request.tk" # the base hostname & protocol for your site, e.g. http://example.com
twitter_username: sushdagr8
url: "https://sushant-j.github.io/my-first-pull-request" # the base hostname & protocol for your site, e.g. http://example.com
twitter_username: apparentlyquiet
github_username: sushant-j

# Build settings
markdown: kramdown
# theme: minima
theme: minima
plugins:
- jekyll-feed
- jekyll-analytics


jekyll_analytics:
GoogleAnalytics: # Add, if you want to track with Google Analytics
id: UA-6226203-3 # Required - replace with your tracking id
anonymizeIp: false # Optional - Default: false - set to true for anonymized tracking
# Exclude from processing.
# The following items will not be processed, by default. Create a custom list
# to override the default setting.
Expand All @@ -38,4 +44,5 @@ plugins:
# - vendor/bundle/
# - vendor/cache/
# - vendor/gems/
# - vendor/ruby/
# - vendor/ruby/
# theme: jekyll-theme-slate
2 changes: 1 addition & 1 deletion _includes/google-analytics.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
})(window,document,'script','https://www.google-analytics.com/analytics.js','ga');

ga('create', '{{ site.google_analytics }}', 'auto');
ga('create', '{{ UA-6226203-3 }}', 'auto');
ga('send', 'pageview');

</script>
Expand Down
4 changes: 2 additions & 2 deletions _includes/head.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
<title>{% if page.title %}{{ page.title | escape }}{% else %}{{ site.title | escape }}{% endif %}</title>
<meta name="description" content="{{ page.excerpt | default: site.description | strip_html | normalize_whitespace | truncate: 160 | escape }}">

<link rel="stylesheet" href="{{ "/assets/main.css" | relative_url }}">
<link rel="stylesheet" href="{{ "/assets/main.css" | prepend: site.baseurl }}">
<link rel="canonical" href="{{ page.url | replace:'index.html','' | absolute_url }}">
<link rel="alternate" type="application/rss+xml" title="{{ site.title | escape }}" href="{{ "/feed.xml" | relative_url }}">
<script src="https://use.fontawesome.com/d4e1494fc9.js"></script>

{% if jekyll.environment == 'production' and site.google_analytics %}
{% include google-analytics.html %}
{% endif %}
Expand Down
79 changes: 78 additions & 1 deletion _layouts/home.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ <h1 class="page-heading center">Contributors</h1>
<!-- User number 1 -->
<li>
<a href="https://github.com/sushant-j/">
Sushant J
Sushant Joshi
</a>
<a class="" href="https://twitter.com/sushdagr8">
<i class="fa fa-twitter"></i>
Expand All @@ -22,5 +22,82 @@ <h1 class="page-heading center">Contributors</h1>
<i class="fa fa-quora"></i>
</a>
</li>
<li>
<a href="https://github.com/purva11198/">
Purva_Chaudhari
</a>
<a href="https://www.facebook.com/purva.chaudhari.5015">
<i class="fa fa-facebook"></i>
</a>
<a href="https://www.quora.com/profile/Purva-Chaudhari">
<i class="fa fa-quora"></i>
</a>
</li>
<li>
<a href="https://github.com/DanishSiraj">
Danish Siraj
</a>
<a class="" href="https://www.linkedin.com/in/danish-siraj-52a034147/">
<i class="fa fa-linkedin"></i>
</a>
<a href="https://facebook.com/danish.wani.100">
<i class="fa fa-facebook"></i>
</a>
<a class="" href="https://twitter.com/DanishWani100">
<i class="fa fa-twitter"></i>
</a>
</li>
<li>
<a href="https://github.com/RushikeshJachak">
Rushikesh J
</a>
<a href="https://www.facebook.com/profile/rockzzrushi0203">
<i class="fa fa-facebook"></i>
</a>
<a href="https://www.quora.com/profile/Rushikesh-Jachak">
<i class="fa fa-quora"></i>
</a>
</li>
<li>
<a href="https://github.com/Bumsquest/">
Shubham Shirpurkar
</a>
<a class="" href="https://twitter.com/TruManUtdFan">
<i class="fa fa-twitter"></i>
</a>
</li>
<li>
<a href="https://github.com/mayurcybercz/">
Mayur R
</a>
<a class="" href="https://twitter.com/mayur.cybercz640">
<i class="fa fa-twitter"></i>
</a>
</li>
<li>
<a href="https://github.com/ida-09/">
Aditya M
</a>
</li>
<li>
<a href="https://github.com/zainabnomi/">
Zainab Nomi
</a>
</li>
<li>
<a href="https://github.com/tusharulhare/">
Tushar Ulhare
</a>
</li>
<li>
<a href="https://github.com/shrikantdaund0693/">
Shrikant Daund
</a>
</li>
<li>
<a href="https://github.com/shilpapundge">
Shilpa Pundge
</a>
</li>
</ol>
</div>
Loading