fixed issue alibaba#16 , optimizer open cursors

BulkSecurityGeneratorProjectV2 · Jun 22, 2016 · ce5ac2c · ce5ac2c
1 parent c265918
commit ce5ac2c
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/src/main/java/com/taobao/yugong/common/db/meta/TableMetaGenerator.java b/src/main/java/com/taobao/yugong/common/db/meta/TableMetaGenerator.java
@@ -70,6 +70,7 @@ public Object doInConnection(Connection conn) throws SQLException, DataAccessExc
                         break;
                     }
                 }
+                rs.close();
 
                 if (table == null) {
                     throw new YuGongException("table[" + schemaName + "." + tableName + "] is not found");
@@ -92,6 +93,7 @@ public Object doInConnection(Connection conn) throws SQLException, DataAccessExc
                         columnList.add(col);
                     }
                 }
+                rs.close();
 
                 // 查询主键信息
                 List<String> primaryKeys = new ArrayList<String>();
@@ -105,6 +107,7 @@ public Object doInConnection(Connection conn) throws SQLException, DataAccessExc
                         primaryKeys.add(StringUtils.upperCase(rs.getString(4)));
                     }
                 }
+                rs.close();
 
                 List<String> uniqueKeys = new ArrayList<String>();
                 if (primaryKeys.isEmpty()) {
@@ -130,6 +133,7 @@ public Object doInConnection(Connection conn) throws SQLException, DataAccessExc
                             uniqueKeys.add(StringUtils.upperCase(rs.getString(9)));
                         }
                     }
+                    rs.close();
 
                     // 如果无主键，使用唯一键
                     primaryKeys.addAll(uniqueKeys);
@@ -187,6 +191,7 @@ public Object doInConnection(Connection conn) throws SQLException, DataAccessExc
                         }
                     }
 
+                    rs.close();
                     stmt.close();
                     return result;
                 } else {
@@ -202,6 +207,8 @@ public Object doInConnection(Connection conn) throws SQLException, DataAccessExc
                             result.add(table);
                         }
                     }
+
+                    rs.close();
                     return result;
                 }
             }
@@ -232,6 +239,8 @@ public Object doInConnection(Connection conn) throws SQLException, DataAccessExc
                         indexes.put(columnName, indexName);
                     }
                 }
+
+                rs.close();
                 return indexes;
             }
         });
@@ -268,6 +277,8 @@ public Object doInPreparedStatement(PreparedStatement ps) throws SQLException, D
                 if (rs.next()) {
                     log = rs.getString("log_table");
                 }
+
+                rs.close();
                 return log;
             }
         });
@@ -299,6 +310,7 @@ public Object doInConnection(Connection conn) throws SQLException, DataAccessExc
                         columnList.add(col);
                     }
                 }
+                rs.close();
 
                 // 查询主键信息
                 rs = metaData.getPrimaryKeys(table.getSchema(), table.getSchema(), table.getName());
@@ -313,6 +325,7 @@ public Object doInConnection(Connection conn) throws SQLException, DataAccessExc
                         primaryKeys.add(rs.getString(4));
                     }
                 }
+                rs.close();
 
                 Set<ColumnMeta> columns = new HashSet<ColumnMeta>();
                 Set<ColumnMeta> pks = new HashSet<ColumnMeta>();
@@ -357,6 +370,8 @@ public Object doInPreparedStatement(PreparedStatement ps) throws SQLException, D
                     if (rs.next()) {
                         log = rs.getString("KEYS");
                     }
+
+                    rs.close();
                     return log;
                 }
             });