Skip to content

Type corrections #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2025
Merged

Type corrections #7

merged 3 commits into from
Feb 4, 2025

Conversation

itsme-to
Copy link
Contributor

Hello, I’m submitting this pull request to fix type errors present in the package. Overall, three things have been modified:

  • bool renamed to boolean in certain places.
  • Added imports for the types used in the files.
  • Changed the methods of the APIError class into getters to fix the conflict between error.message and error.message() that both existed.

@Majored
Copy link
Member

Majored commented Feb 4, 2025

Thanks, merging 👍

@Majored Majored merged commit 090cee9 into BuiltByBit:main Feb 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsme-to @Majored