Better artifacts handling #143
Open
+28
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bakhtin <a@bakhtin.net>
Signed-off-by: bakhtin <a@bakhtin.net>
bakhtin
requested review from
efbig,
mempirate,
metachris,
plroman and
thedevbirb
as code owners
thedevbirb
reviewed
Nov 27, 2025
Comment on lines
+62
to
+72
| - name: Install rust | ||
| run: | | ||
| docker build -f Dockerfile.reproducible -t flowproxy:release . | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y | ||
| - name: Extract binary from Docker image | ||
| - name: Build reproducible binary with Docker | ||
| run: | | ||
| # Create a temporary container and copy the binary | ||
| docker create --name temp-container flowproxy:release | ||
| docker cp temp-container:/flowproxy ./flowproxy | ||
| docker rm temp-container | ||
| RUST_TOOLCHAIN=$(rustc --version | cut -d' ' -f2) | ||
| docker build -f Dockerfile.reproducible \ | ||
| --build-arg "RUST_TOOLCHAIN=${RUST_TOOLCHAIN}" \ | ||
| -t flowproxy:release \ | ||
| --output type=local,dest=./target . |
Collaborator
There was a problem hiding this comment.
Shouldn't we fetch this from the rust-toolchain.toml file?
Collaborator
There was a problem hiding this comment.
Also GitHub runners should have rustup already installed now
mempirate
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--outputflag. Previously, we used a separate step to create a dummy container just to copy the artifacts.