Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updates #146

Merged
merged 3 commits into from
Jul 4, 2020
Merged

chore: updates #146

merged 3 commits into from
Jul 4, 2020

Conversation

jothamardel
Copy link
Contributor

@jothamardel jothamardel commented Jul 3, 2020 •
edited by jason-ibisi
Loading

Description

  • Heroku update.
  • Add response unit id to location data stored on file

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary inline code documentation
  • I have added tests that prove my fix is effective and that this feature works
  • New and existing unit tests pass locally with my changes

@jothamardel jothamardel added the enhancement New feature or request label Jul 3, 2020
@jothamardel jothamardel added this to the Sprint-3 milestone Jul 3, 2020
@jothamardel jothamardel self-assigned this Jul 3, 2020
@jothamardel jothamardel linked an issue Jul 3, 2020 that may be closed by this pull request
Updates #147
Closed
jason-ibisi
jason-ibisi previously approved these changes Jul 3, 2020
View reviewed changes
Ose-Me
Ose-Me previously approved these changes Jul 3, 2020
View reviewed changes
@jothamardel jothamardel dismissed stale reviews from Ose-Me and jason-ibisi via 0b19e5c July 3, 2020 17:30
@jothamardel jothamardel requested review from jason-ibisi and Ose-Me July 3, 2020 17:34
@jason-ibisi jason-ibisi changed the title Ch update chore: updates Jul 3, 2020
@jason-ibisi jason-ibisi merged commit f08ae0d into develop Jul 4, 2020
@jason-ibisi jason-ibisi deleted the ch-update branch July 4, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-ibisi jason-ibisi jason-ibisi approved these changes

@nonsoo24 nonsoo24 nonsoo24 approved these changes

@oluwaseunsamuel oluwaseunsamuel Awaiting requested review from oluwaseunsamuel

@Ose-Me Ose-Me Awaiting requested review from Ose-Me

Assignees

@jothamardel jothamardel

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint-3
Development

Successfully merging this pull request may close these issues.

Updates
4 participants
@jothamardel @jason-ibisi @nonsoo24 @Ose-Me