Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: styling on mobile and victim card modal #145

Merged
merged 8 commits into from
Jun 24, 2020
Merged

chore: styling on mobile and victim card modal #145

merged 8 commits into from
Jun 24, 2020

Conversation

Ose-Me
Copy link
Contributor

@Ose-Me Ose-Me commented Jun 24, 2020

Description

Fixes styling issues noticed on mobile and also the victim card modal

Fixes #130

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary inline code documentation
  • I have added tests that prove my fix is effective and that this feature works
  • New and existing unit tests pass locally with my changes

@Ose-Me Ose-Me added this to the Sprint-3 milestone Jun 24, 2020
@Ose-Me Ose-Me changed the title Ch fixes style fixes Jun 24, 2020
@jason-ibisi jason-ibisi changed the title style fixes chore: styling on mobile and victim card modal Jun 24, 2020
@jason-ibisi jason-ibisi merged commit feded52 into develop Jun 24, 2020
@jason-ibisi jason-ibisi deleted the ch-fixes branch June 24, 2020 15:05
oluwaseunsamuel
oluwaseunsamuel reviewed Jun 24, 2020
View reviewed changes
Copy link

@oluwaseunsamuel oluwaseunsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oluwaseunsamuel oluwaseunsamuel oluwaseunsamuel left review comments

@jason-ibisi jason-ibisi jason-ibisi approved these changes

@jothamardel jothamardel jothamardel approved these changes

@nonsoo24 nonsoo24 Awaiting requested review from nonsoo24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint-3
Development

Successfully merging this pull request may close these issues.

Fix styling Issues
4 participants
@Ose-Me @jason-ibisi @jothamardel @oluwaseunsamuel