Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Display messages from API #142

Merged
merged 5 commits into from
Jun 23, 2020
Merged

Chore: Display messages from API #142

merged 5 commits into from
Jun 23, 2020

Conversation

jothamardel
Copy link
Contributor

@jothamardel jothamardel commented Jun 23, 2020 •
edited
Loading

Description

Display API response to signup, login pages.

Screenshots (if applicable, else remove this line / section)

Screenshot from 2020-06-23 12-08-20
Screenshot from 2020-06-23 12-27-06

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary inline code documentation
  • I have added tests that prove my fix is effective and that this feature works
  • New and existing unit tests pass locally with my changes

@jothamardel jothamardel added the enhancement New feature or request label Jun 23, 2020
@jothamardel jothamardel added this to the Sprint-3 milestone Jun 23, 2020
@jothamardel jothamardel self-assigned this Jun 23, 2020
@jothamardel jothamardel linked an issue Jun 23, 2020 that may be closed by this pull request
Display API response. #141
Closed
jason-ibisi
jason-ibisi previously approved these changes Jun 23, 2020
View reviewed changes
@jothamardel jothamardel requested a review from jason-ibisi June 23, 2020 11:39
jason-ibisi
jason-ibisi previously approved these changes Jun 23, 2020
View reviewed changes
@jothamardel jothamardel dismissed stale reviews from oluwaseunsamuel and jason-ibisi via 7a28cae June 23, 2020 20:51
@jason-ibisi jason-ibisi merged commit 096aa6a into develop Jun 23, 2020
oluwaseunsamuel
oluwaseunsamuel reviewed Jun 24, 2020
View reviewed changes
Copy link

@oluwaseunsamuel oluwaseunsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review approved

@jason-ibisi jason-ibisi deleted the ch-api-response branch June 24, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oluwaseunsamuel oluwaseunsamuel oluwaseunsamuel left review comments

@Ose-Me Ose-Me Awaiting requested review from Ose-Me

@nonsoo24 nonsoo24 Awaiting requested review from nonsoo24

@jason-ibisi jason-ibisi Awaiting requested review from jason-ibisi

Assignees

@jothamardel jothamardel

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint-3
Development

Successfully merging this pull request may close these issues.

Display API response.
3 participants
@jothamardel @jason-ibisi @oluwaseunsamuel