Repository navigation
Give Node room for the whole domain's cookies - #2
Merged
Merged
Conversation
Deployed under a subdomain of bctap.org, so the browser sends every cookie scoped to the parent domain with each request — including Cognito's access, id and refresh JWTs. Node caps request headers at 16k and answers 431 on its own, before nginx's own limit is even reached. Found by testing a ladder of cookie sizes rather than stopping at the first one that passed: raising nginx alone fixed 9k and still failed at 16k.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosted under a subdomain of
bctap.org, so every cookie scoped to the parent domain arrives with each request — Cognito's access, id and refresh JWTs among them. Node caps request headers at 16k and returns 431 before nginx's own limit is reached.nginx needs matching headroom too; that lives in the infra repo as a
conf.ddrop-in.