Remove handlebars-utils package #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwho
reviewed
Dec 2, 2024
| glogg "^1.0.0" | ||
|
|
||
| handlebars-utils@^1.0.4, handlebars-utils@^1.0.6: | ||
| handlebars-utils@^1.0.4: |
There was a problem hiding this comment.
Due the maze of dependencies, this is still used for a dev package called "verb". This should probably not be needed, but given that is a dev dependency we should be good for now
Good shout! Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove handlebars-utils package. The newly introduced code comes from the removed package, being copied in here.
The original repo is making use of a lot of small packages that depend on each other. As we want to migrate to ES, we have 2 options:
Given that the packages are quite small and most of them don't do much, we decided to copy the code over. This will also allow us refactoring and cleaning the code much easier.