Switches the Icon component so that it now uses Remix like the rest of budibase #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,7 @@ | |||
| <html> | |||
| <head> | |||
| <link rel="stylesheet" href="https://rsms.me/inter/inter.css"> | |||
| <link href="https://cdn.jsdelivr.net/npm/remixicon@2.5.0/fonts/remixicon.css" rel="stylesheet"> | |||
There was a problem hiding this comment.
Should we import the CSS for remix in the icon component itself? That way it will get bundled with the client apps.
There was a problem hiding this comment.
I think that would be better, struggled a lot with sorting it out though, got it working in the builder but then I had issues in the actual preview and generated apps. Looked like a pathing issue. Open to suggestions and/or help on how to do it. 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches out the icon library, now uses remix rather than fontawesome. I decided to ditch the idea of using categories, it looks way to cluttered in my opinion.
Screenshots
https://cln.sh/SbeiSl